Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Mirsad Todorovac <mtodorovac69@gmail.com>
To: Mirsad Todorovac <mtodorovac69@gmail.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Nilesh Javali <njavali@marvell.com>,
	GR-QLogic-Storage-Upstream@marvell.com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the end of structures
Date: Thu, 24 Oct 2024 00:17:01 +0200	[thread overview]
Message-ID: <20241023221700.220063-2-mtodorovac69@gmail.com> (raw)

Coccinelle advised modern C99-style flexible arrays instead of array[1] as the closing
member of the struct:

./drivers/scsi/qla2xxx/qla_dbg.h:34:8-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
./drivers/scsi/qla2xxx/qla_dbg.h:87:8-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
./drivers/scsi/qla2xxx/qla_dbg.h:126:8-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
./drivers/scsi/qla2xxx/qla_dbg.h:165:8-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
./drivers/scsi/qla2xxx/qla_dbg.h:213:8-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)

Fixes: 21038b0900d1b ("scsi: qla2xxx: Fix endianness annotations in header files")
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Nilesh Javali <njavali@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Mirsad Todorovac <mtodorovac69@gmail.com>
---
 v1: initial patch to conform to C99 standard.

 drivers/scsi/qla2xxx/qla_dbg.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h
index 54f0a412226f..ca9304df484b 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.h
+++ b/drivers/scsi/qla2xxx/qla_dbg.h
@@ -31,7 +31,7 @@ struct qla2300_fw_dump {
 	__be16 fpm_b1_reg[64];
 	__be16 risc_ram[0xf800];
 	__be16 stack_ram[0x1000];
-	__be16 data_ram[1];
+	__be16 data_ram[];
 };
 
 struct qla2100_fw_dump {
@@ -84,7 +84,7 @@ struct qla24xx_fw_dump {
 	__be32	fpm_hdw_reg[192];
 	__be32	fb_hdw_reg[176];
 	__be32	code_ram[0x2000];
-	__be32	ext_mem[1];
+	__be32	ext_mem[];
 };
 
 struct qla25xx_fw_dump {
@@ -123,7 +123,7 @@ struct qla25xx_fw_dump {
 	__be32	fpm_hdw_reg[192];
 	__be32	fb_hdw_reg[192];
 	__be32	code_ram[0x2000];
-	__be32	ext_mem[1];
+	__be32	ext_mem[];
 };
 
 struct qla81xx_fw_dump {
@@ -162,7 +162,7 @@ struct qla81xx_fw_dump {
 	__be32	fpm_hdw_reg[224];
 	__be32	fb_hdw_reg[208];
 	__be32	code_ram[0x2000];
-	__be32	ext_mem[1];
+	__be32	ext_mem[];
 };
 
 struct qla83xx_fw_dump {
@@ -210,7 +210,7 @@ struct qla83xx_fw_dump {
 	__be32	fb_hdw_reg[432];
 	__be32	at0_array_reg[128];
 	__be32	code_ram[0x2400];
-	__be32	ext_mem[1];
+	__be32	ext_mem[];
 };
 
 #define EFT_NUM_BUFFERS		4
-- 
2.43.0


             reply	other threads:[~2024-10-23 22:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 22:17 Mirsad Todorovac [this message]
2024-10-23 22:25 ` [PATCH v1 1/1] scsi: gla2xxx: use flexible array member at the end of structures Bart Van Assche
2024-10-24  4:22   ` Mirsad Todorovac
2024-10-24 16:55     ` Bart Van Assche
2024-10-26  7:56       ` Mirsad Todorovac
2024-10-24 20:03 ` kernel test robot
2024-10-25 10:57 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023221700.220063-2-mtodorovac69@gmail.com \
    --to=mtodorovac69@gmail.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox