From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B23C212D2B for ; Thu, 7 Nov 2024 15:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730994180; cv=none; b=ECdQ6q/8e6wtoUowBw1O3rvQF3RU6e1vhi/loc69oLL8pSEplkOhC/1oUq8uYAHqgF5PhiPjNu9zlux9VVsaDJCrV5w9zCPCKPjl1qgOVXNfreL3jI3Ndux/XOorURgWQZTMN1B4q3rJMd0da0Jc2wlBN5VEAyRMTVs8oSB2Vi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730994180; c=relaxed/simple; bh=Ocmes03GIEV9WM7tB2F9fJ9RCQvkMK/gGRTXEm0UrE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VmtVPPAgf+zzzcHcGfVRMxBsKrdvdk0tczQbmkltRq+1/tt+LxNNpVsfGaXItIcX6NwqE3RtaAM6BOy7LDA6Jr1gxaOfiUx8waMkJAVAB/YkEgUww6y8VtdwEzEzFwl4LmbYVynXsqqZ1MvHJG/aG5DG7W7bXedlHCu6CkXRBVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o1023zAF; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o1023zAF" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-37d495d217bso921218f8f.0 for ; Thu, 07 Nov 2024 07:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730994176; x=1731598976; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YobGRMTq6r2m1GLqKYMeMjlD+pYxCKxFlYRpMg1uhDo=; b=o1023zAFp0lte7Ic7ugx0xUfx3RWv3ska/IsS8tip11XrDXzOj6tUT2POZjl3NQwN1 pIy5zGN95mOmDAZP12Bsz6YJn0HWJ1AdT/g01eGbAEgHTcM4xHaME6SWIzpgW1wj1Maz 7a9wDJtiU7w9NLvgdrO5lr78t3SXiUXx/S1tmwFS6OYXfOSloa8slYQyQUTVlQsNYS/b zoeisTcpWav6tRfwORBI3aUkHIajsqDbcXL4Z/Agbd9JVsgFxLp4QWjWr1GaFpZQuHCH cBQjbe3jr52E0gfegQFoW9HbP4dhTL/MF3qNdcpJn7WvkAbKUNgEnrOiuAni4ggKY9GQ MgYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730994176; x=1731598976; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YobGRMTq6r2m1GLqKYMeMjlD+pYxCKxFlYRpMg1uhDo=; b=B2ktJt/f07dqdEDI4wqHLd6tVsbSMpEI2yU5kRiNSBhTdii/xVeErEeBEwIgUdHao9 TE0t94VR9MNdsoqcQs1/2mDOnL6PshKFb47aN3KMlhoI8twHleB7RK9dwXAAtv5C+hSg 2bDghMZou3T3OyS2YdmZ6IaFRyR2wK082xc5rSQwMcU4CbTzkJX8r7gZPAq2sl4ylxge C0JDUxmzPazhXILx33QSogChgJ9EtxwFic5AI2rdUy1MhUrO5OnUAN9w41s850vFqr39 eroCFw+/Rko57Wuz9XB7dJvzQv2wvfjHdu7HHXiiTL4N/ELj5QUp9ozhnujDlHTIfsDY lDRA== X-Forwarded-Encrypted: i=1; AJvYcCWCiKKhz+T5xfN0mkeVdUBaTDaU/S6IJ4JULPK1xg12o3BvF2FrhkaI5uAtTkXXjk7thRg3uBulLI3c@vger.kernel.org X-Gm-Message-State: AOJu0Yz6aavPpJYkDTxV7Dre5aPAnNOa1mHl5RlpXsZUDaKH9ZZe7ipE 3XvDWKWYGticVjfO1ZCKayAnu6QFjjBXwwrcFDHXLMEjr+KccSecTukjA7R59g== X-Google-Smtp-Source: AGHT+IFCgk8JSit4kcsOrIG5RALXryrUw/ReDwKvQwa/P1qPxT2aNSJYDBHM8/WH1Pr9qfT9F1GZig== X-Received: by 2002:a5d:64c5:0:b0:37d:4c40:699 with SMTP id ffacd0b85a97d-381c7a467admr27117943f8f.5.1730994176383; Thu, 07 Nov 2024 07:42:56 -0800 (PST) Received: from thinkpad ([89.101.134.25]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381eda0ed16sm2021217f8f.107.2024.11.07.07.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 07:42:55 -0800 (PST) Date: Thu, 7 Nov 2024 15:42:54 +0000 From: Manivannan Sadhasivam To: Shawn Lin Cc: Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Heiko Stuebner , "Rafael J . Wysocki" , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 2/7] dt-bindings: ufs: Document Rockchip UFS host controller Message-ID: <20241107154254.bpuqspdrymyg3qsa@thinkpad> References: <1730705521-23081-1-git-send-email-shawn.lin@rock-chips.com> <1730705521-23081-3-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1730705521-23081-3-git-send-email-shawn.lin@rock-chips.com> On Mon, Nov 04, 2024 at 03:31:56PM +0800, Shawn Lin wrote: > Document Rockchip UFS host controller for RK3576 SoC. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Shawn Lin > --- > > Changes in v4: > - properly describe reset-gpios > > Changes in v3: > - rename the file to rockchip,rk3576-ufshc.yaml > - add description for reset-gpios > - use rockchip,rk3576-ufshc as compatible > > Changes in v2: > - rename the file > - add reset-gpios > > .../bindings/ufs/rockchip,rk3576-ufshc.yaml | 105 +++++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml > > diff --git a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml > new file mode 100644 > index 0000000..bc4c3de > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ufs/rockchip,rk3576-ufshc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip UFS Host Controller > + > +maintainers: > + - Shawn Lin > + > +allOf: > + - $ref: ufs-common.yaml > + > +properties: > + compatible: > + const: rockchip,rk3576-ufshc > + > + reg: > + maxItems: 5 > + > + reg-names: > + items: > + - const: hci > + - const: mphy > + - const: hci_grf > + - const: mphy_grf > + - const: hci_apb > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: core > + - const: pclk > + - const: pclk_mphy > + - const: ref_out > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 4 > + > + reset-names: > + items: > + - const: biu > + - const: sys > + - const: ufs > + - const: grf > + > + reset-gpios: > + maxItems: 1 > + description: | > + GPIO specifiers for host to reset the whole UFS device including PHY and > + memory. This gpio is active low and should choose the one whose high output > + voltage is lower than 1.5V based on the UFS spec. > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - interrupts > + - power-domains > + - resets > + - reset-names > + - reset-gpios > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + ufs: ufs@2a2d0000 { Could you please use 'ufshc' as the node name as documented in the devicetree spec? - Mani > + compatible = "rockchip,rk3576-ufshc"; > + reg = <0x0 0x2a2d0000 0x0 0x10000>, > + <0x0 0x2b040000 0x0 0x10000>, > + <0x0 0x2601f000 0x0 0x1000>, > + <0x0 0x2603c000 0x0 0x1000>, > + <0x0 0x2a2e0000 0x0 0x10000>; > + reg-names = "hci", "mphy", "hci_grf", "mphy_grf", "hci_apb"; > + clocks = <&cru ACLK_UFS_SYS>, <&cru PCLK_USB_ROOT>, <&cru PCLK_MPHY>, > + <&cru CLK_REF_UFS_CLKOUT>; > + clock-names = "core", "pclk", "pclk_mphy", "ref_out"; > + interrupts = ; > + power-domains = <&power RK3576_PD_USB>; > + resets = <&cru SRST_A_UFS_BIU>, <&cru SRST_A_UFS_SYS>, <&cru SRST_A_UFS>, > + <&cru SRST_P_UFS_GRF>; > + reset-names = "biu", "sys", "ufs", "grf"; > + reset-gpios = <&gpio4 RK_PD0 GPIO_ACTIVE_LOW>; > + }; > + }; > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம்