From: Anastasia Kovaleva <a.kovaleva@yadro.com>
To: <martin.petersen@oracle.com>, <bootc@bootc.net>,
<bostroesser@gmail.com>, <michael.christie@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>,
<linux@yadro.com>
Subject: [PATCH 10/10] target: iscsi: Improve a log message
Date: Fri, 29 Nov 2024 18:30:56 +0300 [thread overview]
Message-ID: <20241129153056.6985-11-a.kovaleva@yadro.com> (raw)
In-Reply-To: <20241129153056.6985-1-a.kovaleva@yadro.com>
Change the log message to a useful one.
Reviewed-by: Dmitriy Bogdanov <d.bogdanov@yadro.com>
Signed-off-by: Anastasia Kovaleva <a.kovaleva@yadro.com>
---
drivers/target/iscsi/iscsi_target_parameters.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c
index 9eae01538696..587a7a69405b 100644
--- a/drivers/target/iscsi/iscsi_target_parameters.c
+++ b/drivers/target/iscsi/iscsi_target_parameters.c
@@ -1143,7 +1143,7 @@ static int iscsi_check_value(struct iscsi_param *param, char *value)
if (iscsi_check_string_or_list_value(param, value) < 0)
return -1;
} else {
- target_err("Huh? 0x%02x\n", param->type);
+ target_err("Unknown parameter: 0x%02x\n", param->type);
return -1;
}
--
2.40.3
prev parent reply other threads:[~2024-11-29 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 15:30 [PATCH 00/10] Improve SCSI target logs Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 01/10] target: core: " Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 02/10] target: Use new log wrappers Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 03/10] target: Fix quoted strings splitting Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 04/10] target: Fix some obvious style problems Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 05/10] target: Add log prefix to all tcm files Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 06/10] target: Remove old prefixes from log messages Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 07/10] target: core: Extend CaW logging Anastasia Kovaleva
2024-11-29 15:30 ` [PATCH 08/10] target: core: Use extended logs where possible Anastasia Kovaleva
2024-11-29 21:05 ` kernel test robot
2024-11-29 22:08 ` kernel test robot
2024-11-29 15:30 ` [PATCH 09/10] target: Use __func__ in logs Anastasia Kovaleva
2024-11-29 15:30 ` Anastasia Kovaleva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129153056.6985-11-a.kovaleva@yadro.com \
--to=a.kovaleva@yadro.com \
--cc=bootc@bootc.net \
--cc=bostroesser@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox