* [PATCH 03/19] scsi: bnx2fc: Use kthread_create_on_cpu()
[not found] <20241211154035.75565-1-frederic@kernel.org>
@ 2024-12-11 15:40 ` Frederic Weisbecker
2025-01-02 17:54 ` Martin K. Petersen
2024-12-11 15:40 ` [PATCH 04/19] scsi: bnx2i: " Frederic Weisbecker
2024-12-11 15:40 ` [PATCH 05/19] scsi: qedi: " Frederic Weisbecker
2 siblings, 1 reply; 6+ messages in thread
From: Frederic Weisbecker @ 2024-12-11 15:40 UTC (permalink / raw)
To: LKML
Cc: Frederic Weisbecker, Saurav Kashyap, Javed Hasan,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, Andrew Morton, Peter Zijlstra,
Thomas Gleixner
Use the proper API instead of open coding it.
However it looks like bnx2fc_percpu_io_thread() kthread could be
replaced by the use of a high prio workqueue instead.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index f49783b89d04..36126030e76d 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -2610,14 +2610,11 @@ static int bnx2fc_cpu_online(unsigned int cpu)
p = &per_cpu(bnx2fc_percpu, cpu);
- thread = kthread_create_on_node(bnx2fc_percpu_io_thread,
- (void *)p, cpu_to_node(cpu),
- "bnx2fc_thread/%d", cpu);
+ thread = kthread_create_on_cpu(bnx2fc_percpu_io_thread,
+ (void *)p, cpu, "bnx2fc_thread/%d");
if (IS_ERR(thread))
return PTR_ERR(thread);
- /* bind thread to the cpu */
- kthread_bind(thread, cpu);
p->iothread = thread;
wake_up_process(thread);
return 0;
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 03/19] scsi: bnx2fc: Use kthread_create_on_cpu()
2024-12-11 15:40 ` [PATCH 03/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
@ 2025-01-02 17:54 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-02 17:54 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: LKML, Saurav Kashyap, Javed Hasan, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
Andrew Morton, Peter Zijlstra, Thomas Gleixner
Frederic,
> Use the proper API instead of open coding it.
>
> However it looks like bnx2fc_percpu_io_thread() kthread could be
> replaced by the use of a high prio workqueue instead.
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 04/19] scsi: bnx2i: Use kthread_create_on_cpu()
[not found] <20241211154035.75565-1-frederic@kernel.org>
2024-12-11 15:40 ` [PATCH 03/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
@ 2024-12-11 15:40 ` Frederic Weisbecker
2025-01-02 17:55 ` Martin K. Petersen
2024-12-11 15:40 ` [PATCH 05/19] scsi: qedi: " Frederic Weisbecker
2 siblings, 1 reply; 6+ messages in thread
From: Frederic Weisbecker @ 2024-12-11 15:40 UTC (permalink / raw)
To: LKML
Cc: Frederic Weisbecker, Nilesh Javali, Manish Rangankar,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, Andrew Morton, Peter Zijlstra,
Thomas Gleixner
Use the proper API instead of open coding it.
However it looks like bnx2i_percpu_io_thread() kthread could be
replaced by the use of a high prio workqueue instead.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
drivers/scsi/bnx2i/bnx2i_init.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 872ad37e2a6e..cecc3a026762 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -415,14 +415,11 @@ static int bnx2i_cpu_online(unsigned int cpu)
p = &per_cpu(bnx2i_percpu, cpu);
- thread = kthread_create_on_node(bnx2i_percpu_io_thread, (void *)p,
- cpu_to_node(cpu),
- "bnx2i_thread/%d", cpu);
+ thread = kthread_create_on_cpu(bnx2i_percpu_io_thread, (void *)p,
+ cpu, "bnx2i_thread/%d");
if (IS_ERR(thread))
return PTR_ERR(thread);
- /* bind thread to the cpu */
- kthread_bind(thread, cpu);
p->iothread = thread;
wake_up_process(thread);
return 0;
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 04/19] scsi: bnx2i: Use kthread_create_on_cpu()
2024-12-11 15:40 ` [PATCH 04/19] scsi: bnx2i: " Frederic Weisbecker
@ 2025-01-02 17:55 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-02 17:55 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: LKML, Nilesh Javali, Manish Rangankar, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
Andrew Morton, Peter Zijlstra, Thomas Gleixner
Frederic,
> Use the proper API instead of open coding it.
>
> However it looks like bnx2i_percpu_io_thread() kthread could be
> replaced by the use of a high prio workqueue instead.
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 05/19] scsi: qedi: Use kthread_create_on_cpu()
[not found] <20241211154035.75565-1-frederic@kernel.org>
2024-12-11 15:40 ` [PATCH 03/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
2024-12-11 15:40 ` [PATCH 04/19] scsi: bnx2i: " Frederic Weisbecker
@ 2024-12-11 15:40 ` Frederic Weisbecker
2025-01-02 17:55 ` Martin K. Petersen
2 siblings, 1 reply; 6+ messages in thread
From: Frederic Weisbecker @ 2024-12-11 15:40 UTC (permalink / raw)
To: LKML
Cc: Frederic Weisbecker, Nilesh Javali, Manish Rangankar,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, Andrew Morton, Peter Zijlstra,
Thomas Gleixner
Use the proper API instead of open coding it.
However it looks like qedi_percpu_io_thread() kthread could be
replaced by the use of a high prio workqueue instead.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
drivers/scsi/qedi/qedi_main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 628d59dda20c..f2bb49019617 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1961,13 +1961,11 @@ static int qedi_cpu_online(unsigned int cpu)
struct qedi_percpu_s *p = this_cpu_ptr(&qedi_percpu);
struct task_struct *thread;
- thread = kthread_create_on_node(qedi_percpu_io_thread, (void *)p,
- cpu_to_node(cpu),
- "qedi_thread/%d", cpu);
+ thread = kthread_create_on_cpu(qedi_percpu_io_thread, (void *)p,
+ cpu, "qedi_thread/%d");
if (IS_ERR(thread))
return PTR_ERR(thread);
- kthread_bind(thread, cpu);
p->iothread = thread;
wake_up_process(thread);
return 0;
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 05/19] scsi: qedi: Use kthread_create_on_cpu()
2024-12-11 15:40 ` [PATCH 05/19] scsi: qedi: " Frederic Weisbecker
@ 2025-01-02 17:55 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-02 17:55 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: LKML, Nilesh Javali, Manish Rangankar, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
Andrew Morton, Peter Zijlstra, Thomas Gleixner
Frederic,
> Use the proper API instead of open coding it.
>
> However it looks like qedi_percpu_io_thread() kthread could be
> replaced by the use of a high prio workqueue instead.
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread