Re: [PATCH v4 01/11] libnvdimm: Replace namespace_match() with device_find_child_by_name()

Jonathan Cameron
2024-12-23T20:23:45Z

On Wed, 11 Dec 2024 08:08:03 +0800
Zijun Hu <zijun_hu@icloud.com> wrote:

> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> Simplify nd_namespace_store() implementation by
> using device_find_child_by_name().
>
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> drivers/nvdimm/claim.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
> index 030dbde6b0882050c90fb8db106ec15b1baef7ca..9e84ab411564f9d5e7ceb687c6491562564552e3 100644
> --- a/drivers/nvdimm/claim.c
> +++ b/drivers/nvdimm/claim.c
> @@ -67,13 +67,6 @@ bool nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach,
> return claimed;
> }
>
> -static int namespace_match(struct device *dev, void *data)
> -{
> - char *name = data;
> -
> - return strcmp(name, dev_name(dev)) == 0;
> -}
> -
> static bool is_idle(struct device *dev, struct nd_namespace_common *ndns)
> {
> struct nd_region *nd_region = to_nd_region(dev->parent);
> @@ -168,7 +161,7 @@ ssize_t nd_namespace_store(struct device *dev,
> goto out;
> }
>
> - found = device_find_child(dev->parent, name, namespace_match);
> + found = device_find_child_by_name(dev->parent, name);
> if (!found) {
> dev_dbg(dev, "'%s' not found under %s\n", name,
> dev_name(dev->parent));
>