Re: [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

Jonathan Cameron
2024-12-23T20:45:23Z

On Wed, 11 Dec 2024 08:08:10 +0800
Zijun Hu <zijun_hu@icloud.com> wrote:

> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> gpio_sim_dev_match_fwnode() is a simple wrapper of API
> device_match_fwnode().
>
> Remove the needless wrapper and use the API instead.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> drivers/gpio/gpio-sim.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
> return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip);
> }
>
> -static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data)
> -{
> - return device_match_fwnode(dev, data);
> -}
> -
> static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
> {
> struct gpio_sim_chip *chip;
> @@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
> if (ret)
> return ret;
>
> - chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode);
> + chip->dev = device_find_child(dev, swnode, device_match_fwnode);
> if (!chip->dev)
> return -ENODEV;
>
>