Re: [PATCH v4 09/11] driver core: Introduce an device matching API device_match_type()

Jonathan Cameron
2024-12-23T20:46:10Z

On Wed, 11 Dec 2024 08:08:11 +0800
Zijun Hu <zijun_hu@icloud.com> wrote:

> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> Introduce device_match_type() for purposes below:
>
> - Test if a device matches with a specified device type.
> - As argument of various device finding APIs to find a device with
> specified type.
>
> device_find_child() will use it to simplify operations later.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Seems useful enough to have a generic helper.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/base/core.c | 6 ++++++
> include/linux/device/bus.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 289f2dafa8f3831931d0f316d66ee12c2cb8a2e1..8bdbc9e657e832a063542391426f570ccb5c18b9 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -5228,6 +5228,12 @@ int device_match_name(struct device *dev, const void *name)
> }
> EXPORT_SYMBOL_GPL(device_match_name);
>
> +int device_match_type(struct device *dev, const void *type)
> +{
> + return dev->type == type;
> +}
> +EXPORT_SYMBOL_GPL(device_match_type);
> +
> int device_match_of_node(struct device *dev, const void *np)
> {
> return dev->of_node == np;
> diff --git a/include/linux/device/bus.h b/include/linux/device/bus.h
> index cdc4757217f9bb4b36b5c3b8a48bab45737e44c5..bc3fd74bb763e6d2d862859bd2ec3f0d443f2d7a 100644
> --- a/include/linux/device/bus.h
> +++ b/include/linux/device/bus.h
> @@ -131,6 +131,7 @@ typedef int (*device_match_t)(struct device *dev, const void *data);
>
> /* Generic device matching functions that all busses can use to match with */
> int device_match_name(struct device *dev, const void *name);
> +int device_match_type(struct device *dev, const void *type);
> int device_match_of_node(struct device *dev, const void *np);
> int device_match_fwnode(struct device *dev, const void *fwnode);
> int device_match_devt(struct device *dev, const void *pdevt);
>