Re: [PATCH 05/10] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues

Christoph Hellwig
2025-01-06T11:05:37Z

On Mon, Jan 06, 2025 at 04:31:23PM +0530, Nilay Shroff wrote:
> > +static bool bdev_can_poll(struct block_device *bdev)
> > +{
> > + struct request_queue *q = bdev_get_queue(bdev);
> > +
> > + if (queue_is_mq(q))
> > + return blk_mq_can_poll(q->tag_set);
> > + return q->limits.features & BLK_FEAT_POLL;
> > +}
> > +
>
> Should we make bdev_can_poll() inline ?

I don't really see the point. It's file local and doesn't have any
magic that could confuse the code generator, so we might as well leave
it to the compiler. Although that might be about to change per the
discussion with Damien, which could require it in blk-sysfs, in
which case it should become an inline in a header.