From: Kohei Enju <enjuk@amazon.com>
To: <markus.elfring@web.de>
Cc: <enjuk@amazon.com>, <kohei.enju@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<martin.petersen@oracle.com>, <target-devel@vger.kernel.org>
Subject: Re: [PATCH] scsi: target: remove unnecessary null checking for bio allocation
Date: Sun, 2 Feb 2025 23:30:27 +0900 [thread overview]
Message-ID: <20250202143027.9824-1-enjuk@amazon.com> (raw)
In-Reply-To: <5b946d09-f67c-4a49-bba7-d73a549969b6@web.de>
> > When __GFP_DIRECT_RECLAIM (included in GFP_NOIO) is specified,
> > bio_alloc_bioset() never fails to allocate a bio. For more details, see
> > the comment in bio_alloc_bioset() in block/bio.c
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94
Thanks. I'll modify the commit message into imperative mood.
> Can a blank line be also omitted together with the mentioned compound statement?
Sure, I think so.
I'll submit a v2 patch with the modified commit message and without the blank line.
Regards,
Kohei
prev parent reply other threads:[~2025-02-02 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 9:02 [PATCH v1] scsi: target: remove unnecessary null checking for bio allocation Kohei Enju
2025-02-02 13:56 ` [PATCH] " Markus Elfring
2025-02-02 14:30 ` Kohei Enju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250202143027.9824-1-enjuk@amazon.com \
--to=enjuk@amazon.com \
--cc=kohei.enju@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox