From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1482020E6F9 for ; Wed, 19 Feb 2025 17:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739986083; cv=none; b=uyFxKsbqweJ+uJL3OsRuZ9DoatqclwmMUwlSHO4Q6wnj2VHpnl0HbFX/s5obpzqChq30oHf341nnpoLIsIgmE+cK7zxjiVpd5EJDd/4NUSk45mtw6MEYWjsoacfveaZMxmOlFIDTtsKLaoHBcewCM+LFOk+Hx1jBdRvEMxsUac8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739986083; c=relaxed/simple; bh=A2+HN4X0kozADOMd8HPrxpMBAxhu8YWTaMSPkwDk7qU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p7ydmW7R5aF2e+otcdkKkH39A69NeV6BwMkVG5/p8nxMUjtDCYl5DlH7b6P7QDr3TJEwIxreLmvYqLmCm5dB5F0yROhYwo0OF1mQfINJoDK3FEcXavE50Ye8vOOFeUmoUgXommZ/eW7zUT4HQskczycOJc6Xw/ZCuu0PINJWmBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WMIIVk5X; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WMIIVk5X" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2fc1c80cdc8so52752a91.2 for ; Wed, 19 Feb 2025 09:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739986081; x=1740590881; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6NzngaP+OJcFLsyG7y1oBQVz797WX/iYaGWrcxV/1GA=; b=WMIIVk5X/P+UcTpYed8sUaeBw6DrbuXb7SgnrczGTSV8LecrH+o+PyTU3QQcdj+E15 Y2LPES0UK3byQR0gsU5DLnrE1Q9hVq4H/FSpF3HnSQ7VboN5lyJieC0B9SSKcDZmqtut OpzXX2/Od0w9rDn82DN8c/Nz0YNoMn9V2jxYorO9EPqhN5z69JpHX4HvwyT3Y0fqGcRp u5uHrVKTf7EbafgQtPj6pXS4LEjLpshA3no4C9tKoTF+q/nvI4OxiOoMGQH20tdrOBeS mN1h9gbNSiqN2oI5RKT5DtO0WDDZNSsQDViQYbIzMBX3v+fHq3pv//8vQ64/iQR41Ijc IzbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739986081; x=1740590881; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6NzngaP+OJcFLsyG7y1oBQVz797WX/iYaGWrcxV/1GA=; b=n4T2469IOvbzreZYF2EzNpXYa9XPQS9vJZw8nlShgVRqbi4rXWfvu/Yt4F97wg/ozz FEEW7rHYquPnxSYduOMC7hoxIc3o7i7KJj9RysylUv6hpo18Gny5vcbRdJJogh6iWsq1 pY0RM1mCfZ17RadJwucuQ+wTOp29nKFVoETaWPTUAnj6PNrP0vmhzCoW4cwbGWqGewRj JYfVkTiFOtVMgzmSJyazlAcr6Eeddz7G8msUi5qohNvat6s6lb77Z+tUdrPj8JBuw5gt l3+hRxzFrGAYMTKBjSKP8JJBoQGZd7Jc4cmz7q3js5mba1+Mw4iAt9J99JO8vgHJ8PH4 qcdA== X-Forwarded-Encrypted: i=1; AJvYcCX2ho/K+6eh0l3t+n2kFDPZiUH+pUi5FxABUiXK8fk/o51GlrG5+eTVqnMlHD3CfbGnNwrgDWJq0GyI@vger.kernel.org X-Gm-Message-State: AOJu0YyUas0PgQNAcm5uyWBIF5BBnxV1g+ypH7xf6/p2v8NbrO8pBNPt 3POcQkI50SR7WFwGg1GrNbDwsJXJuHWJgxbmFuMF0ZBEAz0MJwE6LdwDsWg4sw== X-Gm-Gg: ASbGncsnYo7lECX00R36/CJKrZHGgtHc/tuzzxKgFMXnR24RQUhmE2jqDUA6vOBoWQv hRX3PXcqaAStzNTWy2+H3x8qYaygAPvSUHL/nUia2KM+Ieslb/NCJRHp0O5iWlsCxp9lH9V/yQD qB6KEObM9XFzUV4Xd0q0A/ZxeRo0w8HSHtkgK+5HQekFN6eRtw3NiDzp0JDLDp+vCVzCssrsaAN ARE5DL3ZTX7pLiumJiijP1aeJd0eiouQly1MgExyTbk0ZBhe2GWcbXP3cs1TsW4fj8SizNmPcvc SIc+xgsq2aMJcEPcVgLBnNTHWg== X-Google-Smtp-Source: AGHT+IHOShpnSsF84pZmQWIv/xBAmLajjHNqHii8bXec9NnuKW9M7BOSWjuz/fRYPwl+0byTPs9X6w== X-Received: by 2002:a17:90b:1b06:b0:2ea:2a8d:dd2a with SMTP id 98e67ed59e1d1-2fcb5a996cdmr6581509a91.27.1739986081323; Wed, 19 Feb 2025 09:28:01 -0800 (PST) Received: from thinkpad ([120.60.141.99]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fbf999b5b4sm15735500a91.30.2025.02.19.09.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 09:28:01 -0800 (PST) Date: Wed, 19 Feb 2025 22:57:55 +0530 From: Manivannan Sadhasivam To: "Bao D. Nguyen" Cc: quic_cang@quicinc.com, quic_nitirawa@quicinc.com, bvanassche@acm.org, avri.altman@wdc.com, peter.wang@mediatek.com, minwoo.im@samsung.com, adrian.hunter@intel.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley" , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , open list Subject: Re: [PATCH 1/1] scsi: ufs: qcom: Remove dead code in ufs_qcom_cfg_timers() Message-ID: <20250219172755.b2jq5joh7nrrf6rr@thinkpad> References: <547c484ce80fe3624ee746954b84cae28bd38a09.1739985266.git.quic_nguyenb@quicinc.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <547c484ce80fe3624ee746954b84cae28bd38a09.1739985266.git.quic_nguyenb@quicinc.com> On Wed, Feb 19, 2025 at 09:16:06AM -0800, Bao D. Nguyen wrote: > Since 'commit 104cd58d9af8 ("scsi: ufs: qcom: > Remove support for host controllers older than v2.0")', > some of the parameters passed into the ufs_qcom_cfg_timers() > function have become dead code. Clean up ufs_qcom_cfg_timers() > function to improve the readability. > > Signed-off-by: Bao D. Nguyen Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/ufs/host/ufs-qcom.c | 25 ++++--------------------- > 1 file changed, 4 insertions(+), 21 deletions(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 23b9f6e..d89faf6 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -509,16 +509,10 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, > * ufs_qcom_cfg_timers - Configure ufs qcom cfg timers > * > * @hba: host controller instance > - * @gear: Current operating gear > - * @hs: current power mode > - * @rate: current operating rate (A or B) > - * @update_link_startup_timer: indicate if link_start ongoing > * @is_pre_scale_up: flag to check if pre scale up condition. > * Return: zero for success and non-zero in case of a failure. > */ > -static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32 gear, > - u32 hs, u32 rate, bool update_link_startup_timer, > - bool is_pre_scale_up) > +static int ufs_qcom_cfg_timers(struct ufs_hba *hba, bool is_pre_scale_up) > { > struct ufs_qcom_host *host = ufshcd_get_variant(hba); > struct ufs_clk_info *clki; > @@ -534,11 +528,6 @@ static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32 gear, > if (host->hw_ver.major < 4 && !ufshcd_is_intr_aggr_allowed(hba)) > return 0; > > - if (gear == 0) { > - dev_err(hba->dev, "%s: invalid gear = %d\n", __func__, gear); > - return -EINVAL; > - } > - > list_for_each_entry(clki, &hba->clk_list_head, list) { > if (!strcmp(clki->name, "core_clk")) { > if (is_pre_scale_up) > @@ -574,8 +563,7 @@ static int ufs_qcom_link_startup_notify(struct ufs_hba *hba, > > switch (status) { > case PRE_CHANGE: > - if (ufs_qcom_cfg_timers(hba, UFS_PWM_G1, SLOWAUTO_MODE, > - 0, true, false)) { > + if (ufs_qcom_cfg_timers(hba, false)) { > dev_err(hba->dev, "%s: ufs_qcom_cfg_timers() failed\n", > __func__); > return -EINVAL; > @@ -831,9 +819,7 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, > } > break; > case POST_CHANGE: > - if (ufs_qcom_cfg_timers(hba, dev_req_params->gear_rx, > - dev_req_params->pwr_rx, > - dev_req_params->hs_rate, false, false)) { > + if (ufs_qcom_cfg_timers(hba, false)) { > dev_err(hba->dev, "%s: ufs_qcom_cfg_timers() failed\n", > __func__); > /* > @@ -1348,12 +1334,9 @@ static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up) > > static int ufs_qcom_clk_scale_up_pre_change(struct ufs_hba *hba) > { > - struct ufs_qcom_host *host = ufshcd_get_variant(hba); > - struct ufs_pa_layer_attr *attr = &host->dev_req_params; > int ret; > > - ret = ufs_qcom_cfg_timers(hba, attr->gear_rx, attr->pwr_rx, > - attr->hs_rate, false, true); > + ret = ufs_qcom_cfg_timers(hba, true); > if (ret) { > dev_err(hba->dev, "%s ufs cfg timer failed\n", __func__); > return ret; > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம்