From: Anuj Gupta <anuj20.g@samsung.com>
To: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
martin.petersen@oracle.com
Cc: anuj1072538@gmail.com, nikh1092@linux.ibm.com,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org, dm-devel@lists.linux.dev,
Anuj Gupta <anuj20.g@samsung.com>
Subject: [PATCH v1 2/3] nvme: Fix incorrect block integrity sysfs values for non-PI namespaces
Date: Tue, 25 Feb 2025 10:16:52 +0530 [thread overview]
Message-ID: <20250225044653.6867-3-anuj20.g@samsung.com> (raw)
In-Reply-To: <20250225044653.6867-1-anuj20.g@samsung.com>
Commit 9f4aa46f2a74
("block: invert the BLK_INTEGRITY{GENERATE,VERIFY} flags") caused
read_verify and write_generate to report 1 for NVMe namespaces
without PI support. This happens because BLK_INTEGRITY_NOGENERATE and
BLK_INTEGRITY_NOVERIFY were not explicitly set.
Fix this by initializing these flags by default and clearing them only
when the namespace supports PI.
Fixes: 9f4aa46f2a74 ("block: invert the BLK_INTEGRITY_{GENERATE,VERIFY} flags")
Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
---
drivers/nvme/host/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 818d4e49aab5..fe599a811d38 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1799,6 +1799,7 @@ static bool nvme_init_integrity(struct nvme_ns_head *head,
memset(bi, 0, sizeof(*bi));
+ bi->flags = BLK_INTEGRITY_NOGENERATE | BLK_INTEGRITY_NOVERIFY;
if (!head->ms)
return true;
@@ -1850,6 +1851,9 @@ static bool nvme_init_integrity(struct nvme_ns_head *head,
break;
}
+ if (bi->flags & BLK_INTEGRITY_DEVICE_CAPABLE)
+ bi->flags &= ~(BLK_INTEGRITY_NOGENERATE |
+ BLK_INTEGRITY_NOVERIFY);
bi->tuple_size = head->ms;
bi->pi_offset = info->pi_offset;
return true;
--
2.25.1
next prev parent reply other threads:[~2025-02-25 5:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250225045511epcas5p2d89efcac39b6553317e93e8c7fea3f2b@epcas5p2.samsung.com>
2025-02-25 4:46 ` [PATCH v1 0/3] Fix integrity sysfs reporting inconsistencies across NVMe, SCSI, and DM Anuj Gupta
2025-02-25 4:46 ` [PATCH v1 1/3] block: Fix incorrect integrity sysfs reporting for DM devices Anuj Gupta
2025-02-25 15:06 ` Christoph Hellwig
2025-02-26 11:27 ` Anuj gupta
2025-02-25 4:46 ` Anuj Gupta [this message]
2025-02-25 15:07 ` [PATCH v1 2/3] nvme: Fix incorrect block integrity sysfs values for non-PI namespaces Christoph Hellwig
2025-02-25 4:46 ` [PATCH v1 3/3] scsi: Fix incorrect integrity sysfs values when HBA doesn't support DIX Anuj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225044653.6867-3-anuj20.g@samsung.com \
--to=anuj20.g@samsung.com \
--cc=anuj1072538@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nikh1092@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox