From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CE0F1DF75C for ; Tue, 18 Mar 2025 07:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742281522; cv=none; b=mAEjwvRzQcROHu+eC2ZCcEgXBl8nktPesYdk1BsAucsDlICwVWwDolBhi/XBstMPJZCyh6FT6+/4UGQFAJpb8GKbuwGXa/tukYQN7SazXQ5WDOcc57PrHSVMrjwgQ2vi3BxbeDsIDTVthy/4cUdfT0YEUJ67CQWjGwgtSr3AGPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742281522; c=relaxed/simple; bh=qCITQPsy2GwiPIzdSarHb8VqhI6wNrVYai8jeIXLBy4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PhwvWWHcSZ6G41Qsla1/Lcrkr9Dcxsk6KlNTlVoyA+G2oeVCkU21dGWt7qU/6yCPhLbfXQDLGtr0hT0bb/IJdjHuJAXoSIShPaYpqC7atxz+Kx6sMhwix7ejH6Pp7UhVaBTMQHTkpnmafsdfeRK+Ss2cF2qv8pxR5DbT3wVOiR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bc7ovjbU; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bc7ovjbU" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-223fb0f619dso86768865ad.1 for ; Tue, 18 Mar 2025 00:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742281519; x=1742886319; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QXrW4KZykPW/TaRaUNi4OeOrIqggNnusl7chmQ738FU=; b=bc7ovjbULADqDVRybCDAqUjiTgCs3RSyvnUpbOt6AAUfPy1fV8kBtpTuMr2iYl05Kc HxAcs8F1lI7kbpQSjv2QjkrLr+116wIveG5gmOQ1toQp49aVAQJ2Fce6noFDyrFSO1hg 5PAUteT0F8bHwTBNUuExQWcvs4EhLbN6GG99KPfWxZNlMwTV1gMLte3VJ7l8fMyyHgzV 842kkvY864eY24Ymu1Q7F8VwS/annjMHfeSdrdMDbcX97LjmR5Zm3KdZsVjZHIwg5nB1 Bul3vQpiyjfLAnCFMz7m4jJBbTfaPEVBK/XyY+GA7+rudEl71jebrkc1prJcI1wLRo1a Umbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742281519; x=1742886319; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QXrW4KZykPW/TaRaUNi4OeOrIqggNnusl7chmQ738FU=; b=tCWpxMFHns3WOYLJuTDaKsvf/NSyGP9shlj5VOe+eRGnpvfYlM4cFairOeuEGmG2Ke FSeKbRpQXOxaKkiWWHMQQ56YzAzEbCIJCLHPSiUcBM2hEj/qhKDW423aL5CoAA6pw55F p0wPnkNjoEqKf3yo+mwbs4L1+y+mYTdWWoWrpsp8xx8qtlqno3g6Ol4qYXHKPliIYJlt +6W7TtYgmlQZwSc7y/DsZYKE2MH7hqZqvxyGWxqw+IhKlh7gQll2PCAaYML1ktn+4+aQ rTjJhx3cp6OYGpKqSCbVAPx1qW8t+U53HZm8ORMX4pp7ejGMQqbNx0rbq60VY2WNKFfZ Rgcg== X-Forwarded-Encrypted: i=1; AJvYcCVvZJ1VB5+cr7NVedzX2rkRI3Y2plU+XTE9e3icTx00577BdPBzSfIv9ap8CN6MtOcN7bpeZp01gWDP@vger.kernel.org X-Gm-Message-State: AOJu0YyUKCv9/PnHV2JWbY/sKnr8ZfuUe0OvjOMhNQiE1H6YBwkEu7yZ 0YuVT0NrDgr7Ay6PQqCTZtI7ylUs4xAgz2S66RZAxa+xhHZznubwI+OAtZoE5g== X-Gm-Gg: ASbGncuzYTgFa+a4+e0QBwWdipjhddXPOdWGj2rD43mnB4N2A6pkD04X7pMR7R9GSxI 6rTHSYqJrNM6dcaQ1yl9LvFNfVHitEeVxGBjugaPtzM6IpIWZ8G3kqa0VWYsrGo5jEeXaBbMA/X lM81aGFibH9ZFCW6lW+kdxScOW7zcCGE+qDhEecZQTWR1HCOsRvT/Szzg3oldrL/w4bp8IQCuF+ srn5QSKQdviRlnLfb073hS7XyS+36D+UD6F/4zsRH2A8i1PiPqrsa6LtnDnHrwP4DLj6tMiplY2 QVVLXcqob0IgPm7qvakkNGdIZRXG3u27njJA/qVuP4bnXbN/Q3II2uKkImdsHH0OQkk= X-Google-Smtp-Source: AGHT+IFELZZGoPfT6STXRlYgerVWlkmXVkLlEhm+ubQe4itMsy4v3K90wtNq7bLioIFZ/Q1rMqJxyw== X-Received: by 2002:a17:902:f686:b0:221:7eae:163b with SMTP id d9443c01a7336-225e0b09706mr189606415ad.46.1742281518851; Tue, 18 Mar 2025 00:05:18 -0700 (PDT) Received: from thinkpad ([120.56.195.170]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-301536320e1sm7394697a91.36.2025.03.18.00.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 00:05:18 -0700 (PDT) Date: Tue, 18 Mar 2025 12:35:13 +0530 From: Manivannan Sadhasivam To: Manish Pandey Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_nitirawa@quicinc.com, quic_cang@quicinc.com, quic_nguyenb@quicinc.com Subject: Re: [PATCH V3 3/3] scsi: ufs-qcom: Add support for testbus registers Message-ID: <20250318070513.rhl5lfwdu7mo7xv6@thinkpad> References: <20250313051635.22073-1-quic_mapa@quicinc.com> <20250313051635.22073-4-quic_mapa@quicinc.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250313051635.22073-4-quic_mapa@quicinc.com> On Thu, Mar 13, 2025 at 10:46:35AM +0530, Manish Pandey wrote: > This patch introduces support for dumping testbus registers, > enhancing the debugging capabilities for UFS-QCOM drivers. > Same comment as patch 1. > Signed-off-by: Manish Pandey > --- > Changes in v3: > - Annotated the 'testbus' declaration with __free. > - Converted the switch-statements into an array lookup. > - Introduced struct testbus_info{} for handling testbus switch-statements to an array lookup. > Changes in v2: > - Rebased patchsets. > - Link to v1: https://lore.kernel.org/linux-arm-msm/20241025055054.23170-1-quic_mapa@quicinc.com/ > > --- > drivers/ufs/host/ufs-qcom.c | 53 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index fb9da04c0d35..c32b1268d299 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include Sort includes alphabetically. > > #include > > @@ -98,6 +99,24 @@ static const struct __ufs_qcom_bw_table { > [MODE_MAX][0][0] = { 7643136, 819200 }, > }; > > +static const struct { > + int nminor; > + char *prefix; > +} testbus_info[TSTBUS_MAX] = { > + [TSTBUS_UAWM] = {32, "TSTBUS_UAWM "}, > + [TSTBUS_UARM] = {32, "TSTBUS_UARM "}, > + [TSTBUS_TXUC] = {32, "TSTBUS_TXUC "}, > + [TSTBUS_RXUC] = {32, "TSTBUS_RXUC "}, > + [TSTBUS_DFC] = {32, "TSTBUS_DFC "}, > + [TSTBUS_TRLUT] = {32, "TSTBUS_TRLUT "}, > + [TSTBUS_TMRLUT] = {32, "TSTBUS_TMRLUT "}, > + [TSTBUS_OCSC] = {32, "TSTBUS_OCSC "}, > + [TSTBUS_UTP_HCI] = {32, "TSTBUS_UTP_HCI "}, > + [TSTBUS_COMBINED] = {32, "TSTBUS_COMBINED "}, > + [TSTBUS_WRAPPER] = {32, "TSTBUS_WRAPPER "}, > + [TSTBUS_UNIPRO] = {256, "TSTBUS_UNIPRO "} > +}; > + > static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host); > static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, unsigned long freq); > > @@ -1566,6 +1585,33 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host) > return 0; > } > > +static void ufs_qcom_dump_testbus(struct ufs_hba *hba) > +{ > + struct ufs_qcom_host *host = ufshcd_get_variant(hba); > + int i, j, nminor = 0, testbus_len = 0; > + u32 *testbus __free(kfree) = NULL; > + char *prefix; > + > + testbus = kmalloc(256 * sizeof(u32), GFP_KERNEL); Use kmalloc_array(). > + if (!testbus) > + return; > + > + for (j = 0; j < TSTBUS_MAX; j++) { > + nminor = testbus_info[j].nminor; > + prefix = testbus_info[j].prefix; > + host->testbus.select_major = j; > + testbus_len = nminor * sizeof(u32); > + for (i = 0; i < nminor; i++) { > + host->testbus.select_minor = i; > + ufs_qcom_testbus_config(host); > + testbus[i] = ufshcd_readl(hba, UFS_TEST_BUS); > + usleep_range(100, 200); Why this delay is required? > + } > + print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, > + 16, 4, testbus, testbus_len, false); > + } > +} > + > static void ufs_qcom_dump_mcq_hci_regs(struct ufs_hba *hba) > { > /* sleep intermittently to prevent CPU hog during data dumps. */ > @@ -1680,9 +1726,14 @@ static void ufs_qcom_dump_dbg_regs(struct ufs_hba *hba) > > /* ensure below dumps occur only in task context due to blocking calls. */ > if (in_task()) { > - /* Dump MCQ Host Vendor Specific Registers */ > + /* dump MCQ Host Vendor Specific Registers */ Spurious change. > if (hba->mcq_enabled) > ufs_qcom_dump_mcq_hci_regs(hba); > + > + /* sleep a bit intermittently as we are dumping too much data */ > + ufshcd_dump_regs(hba, UFS_TEST_BUS, 4, "UFS_TEST_BUS "); > + usleep_range(1000, 1100); Same comment as previous patch. Use cond_resched(). - Mani -- மணிவண்ணன் சதாசிவம்