Re: [PATCH] scsi: elx: sli4: Replace deprecated strncpy() with strscpy()

Kees Cook
2025-04-07T20:30:49Z

On Mon, Apr 07, 2025 at 09:01:53PM +0200, Thorsten Blum wrote:
> On 7. Apr 2025, at 20:28, Kees Cook wrote:
> > On Wed, Feb 26, 2025 at 07:55:26PM +0100, Thorsten Blum wrote:
> >> strncpy() is deprecated for NUL-terminated destination buffers; use
> >> strscpy() instead.
> >>
> >> Compile-tested only.
> >>
> >> Link: https://github.com/KSPP/linux/issues/90
> >> Cc: linux-hardening@vger.kernel.org
> >> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> >> ---
> >
> > Standard question for these kinds of conversions: Why is it safe that
> > this is not NUL padded? I haven't found where this buffer is being
> > zeroed out, but it probably is (given the "- 1" on the length), but
> > without run-time testing, this needs much more careful analysis.
>
> I think this was submitted before I started to explain this better.
>
> 'wr_obj' is the zeroed out 'buf' returned from sli_config_cmd_init().

I don't see how dma->virt and buf are associated?

>
> I'll update the description and submit a v2.

Thanks!

>
> Thanks,
> Thorsten
>

--
Kees Cook