public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v3 0/4] CDL Feature control improvements
Date: Sat, 19 Apr 2025 08:06:19 +0900	[thread overview]
Message-ID: <20250418230623.375686-1-dlemoal@kernel.org> (raw)

Control of the enable/disable state of an ATA device Command Duration
Limits (CDL) features has issues:
1) Incorrect checks of the feature support for translating a MODE SELECT
   command
2) Incorrect feature state report translation in libata-scsi
3) The state reported when enabling the feature was being ignored, which
   caused needless SET FEATURES commands to be issued to the device,
   thus causing an unwanted reset of the CDL statistics log page (which
   is implied by any CDL activation action).

Patches 2 to 5 patches address these issues. In addition to these, patch
1 corrects an incorrect function return type.

Martin,

I can take the scsi patch if you are OK with it. Or the reverse, you can
take all patches through the scsi tree if you prefer. Please let me
know.

Changes from v2:
 - Dropped the patch "ata: libata-scsi: Fail MODE SELECT for unsupported
   mode pages" (former patch 3) as it wasnot necessary
 - Added review tag to patch 1

Changes from v1:
 - Added Patch 1 and 2
 - Added review tags to patches 3, 4 and 5

Damien Le Moal (4):
  ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type
  ata: libata-scsi: Fix ata_msense_control_ata_feature()
  ata: libata-scsi: Improve CDL control
  scsi: Improve CDL control

 drivers/ata/libata-scsi.c | 25 +++++++++++++++++--------
 drivers/scsi/scsi.c       | 36 ++++++++++++++++++++++++------------
 2 files changed, 41 insertions(+), 20 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-04-18 23:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18 23:06 Damien Le Moal [this message]
2025-04-18 23:06 ` [PATCH v3 1/4] ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type Damien Le Moal
2025-04-18 23:14   ` Igor Pylypiv
2025-04-18 23:06 ` [PATCH v3 2/4] ata: libata-scsi: Fix ata_msense_control_ata_feature() Damien Le Moal
2025-04-18 23:06 ` [PATCH v3 3/4] ata: libata-scsi: Improve CDL control Damien Le Moal
2025-04-18 23:06 ` [PATCH v3 4/4] scsi: " Damien Le Moal
2025-04-22  1:27 ` [PATCH v3 0/4] CDL Feature control improvements Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418230623.375686-1-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox