From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F8AD7603F; Tue, 22 Apr 2025 02:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745288153; cv=none; b=pOybamI0gyTx+RCes2bn9el12fHBRbVMGYZKX+xzi1iq1J4MM/PFr21RlGqbaHvIVZYCz7PkXLySU+QYaw823ezboaqYPMpRQHrFkU4JRP2CGGgmcLjuAfBssnnQ3EjvWaTk/OKnBtR6sy9KKacHIDdk9jYrpv+2gSEc60qlXfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745288153; c=relaxed/simple; bh=z2EH+1qmEKhrQjVr+hqnwccDBw862+F1boPrK7eTsU0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uETQpzLhEooNqj/88xzhiVFPQ7CE/Vr5Ij1KSqrwdYZT4mZg/zalDuapYV87AU+GFqLerfURaCLcAhlnnscKPIDhlkPxjGmIFdBrGjwxO0ILIveghAZcUXe7GPoEPDHOzxrxR3xPsSX/NB3pu3aIP36dH8uN9yPj5q5BTLsGnMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rdrUCUwT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rdrUCUwT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB760C4CEEC; Tue, 22 Apr 2025 02:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745288152; bh=z2EH+1qmEKhrQjVr+hqnwccDBw862+F1boPrK7eTsU0=; h=From:To:Cc:Subject:Date:From; b=rdrUCUwTEZslVPK+nZyuVO6N0XtgxN1kDC85HEBC+UY95dsBJfp/4i0rdF5fwM85f +w2lMwLs6BbRjy/OFW76UDHGpgmEvtnRi27UZ+IovEE+lhR922tbLLaNIdX4a2BudV BZh2kuZDRRD191ogqztU9C9f6ywfW/LiM2zQEtNix1+vSgL4Zi+kjYncjxHOkc7V+c JQT07TK4L30qbxKisCHqGtam9ZsLkM6wnRLz7UpGWLplN0Y0prjlzSUjS6FMyfG3bp EJfekA6sD0Fmrq1cZ0mgiemW7sp1k4M3CpnCScXGPz6UsKokd4CYL2PEjxCw+7zGDH ot78XomN9+mBA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xingui Yang , "Martin K . Petersen" , Sasha Levin , liyihang9@huawei.com, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 01/30] scsi: hisi_sas: Fix I/O errors caused by hardware port ID changes Date: Mon, 21 Apr 2025 22:15:21 -0400 Message-Id: <20250422021550.1940809-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.3 Content-Transfer-Encoding: 8bit From: Xingui Yang [ Upstream commit daff37f00c7506ca322ccfce95d342022f06ec58 ] The hw port ID of phy may change when inserting disks in batches, causing the port ID in hisi_sas_port and itct to be inconsistent with the hardware, resulting in I/O errors. The solution is to set the device state to gone to intercept I/O sent to the device, and then execute linkreset to discard and find the disk to re-update its information. Signed-off-by: Xingui Yang Link: https://lore.kernel.org/r/20250312095135.3048379-3-yangxingui@huawei.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/hisi_sas/hisi_sas_main.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 3596414d970b2..7a484ad0f9abe 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -935,8 +935,28 @@ static void hisi_sas_phyup_work_common(struct work_struct *work, container_of(work, typeof(*phy), works[event]); struct hisi_hba *hisi_hba = phy->hisi_hba; struct asd_sas_phy *sas_phy = &phy->sas_phy; + struct asd_sas_port *sas_port = sas_phy->port; + struct hisi_sas_port *port = phy->port; + struct device *dev = hisi_hba->dev; + struct domain_device *port_dev; int phy_no = sas_phy->id; + if (!test_bit(HISI_SAS_RESETTING_BIT, &hisi_hba->flags) && + sas_port && port && (port->id != phy->port_id)) { + dev_info(dev, "phy%d's hw port id changed from %d to %llu\n", + phy_no, port->id, phy->port_id); + port_dev = sas_port->port_dev; + if (port_dev && !dev_is_expander(port_dev->dev_type)) { + /* + * Set the device state to gone to block + * sending IO to the device. + */ + set_bit(SAS_DEV_GONE, &port_dev->state); + hisi_sas_notify_phy_event(phy, HISI_PHYE_LINK_RESET); + return; + } + } + phy->wait_phyup_cnt = 0; if (phy->identify.target_port_protocols == SAS_PROTOCOL_SSP) hisi_hba->hw->sl_notify_ssp(hisi_hba, phy_no); -- 2.39.5