From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C542625A2AB; Tue, 22 Apr 2025 02:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745288232; cv=none; b=p5Hg4jOkmBZIgh7NSOct57wcXy9AQ4cw0Lu583yxXdbH6EDNaPtOlgPK1kGV0rHyRPScJHNashFuwxLSg6deHQdlT29el4DJb8Vv5Acsn4ORsv8gtqtkLxZ4dxiLdg9KrRdh9NrnaDYz/mmPN/fp91xfK5A6r9zxI3PvSeMLlPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745288232; c=relaxed/simple; bh=dYAV9kglKcUTI7E8go+96gdPhYEE40Ew+7OR2lBPlmo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=um9WHREf5AJnSNSyid2ZJE21s1eEukbwx9WkrN+wbrSKll8aPyGWaj/gkwf/8untVTmaRVnzVwXmICVC85omNKFO4gRqMc73aFV9ih7DPE9A1z5cYEhOzs8L5nKALnT4ksuvba6pCONH48TC+sH57bQPd+GtGNnzV5Fme1SLfgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EphySgD3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EphySgD3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 592D0C4CEEE; Tue, 22 Apr 2025 02:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745288232; bh=dYAV9kglKcUTI7E8go+96gdPhYEE40Ew+7OR2lBPlmo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EphySgD3O6DrAEbf33ZFr2Z5uh4vYNO+6pE3YZEygRg1KjmiOIQ/NDTmgF6adNyPi Dr04JLHbSkzW8FsBTnd3DtxgZ/jiKq/KgEprtAMJDFUrN3FhCrkhpgMypi8/tCFFQd 9smtwD1TqSVZN3h9QfKrKvY3wgw5q39dVpYT8RvCdfnba+aygaBEQT/MU5Uhe3mzdP EwrJYnpp5oQxMX6+7QuFfryQykSGdADtdTn4zi4h5jBJJSOyqzigB90y02ttvacRDp SHDtqlLWQt2fWXoNV5TijsHPsJJCN3vIwgg4+2NfCuLcayLg3oPGhsn9LcZWpRr7tz 63uD2Puit6LhA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Griffin , Bart Van Assche , "Martin K . Petersen" , Sasha Levin , alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, krzk@kernel.org, linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.12 05/23] scsi: ufs: exynos: gs101: Put UFS device in reset on .suspend() Date: Mon, 21 Apr 2025 22:16:45 -0400 Message-Id: <20250422021703.1941244-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250422021703.1941244-1-sashal@kernel.org> References: <20250422021703.1941244-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.24 Content-Transfer-Encoding: 8bit From: Peter Griffin [ Upstream commit cd4c0025069f16fc666c6ffc56c49c9b1154841f ] GPIO_OUT[0] is connected to the reset pin of embedded UFS device. Before powering off the phy assert the reset signal. This is added as a gs101 specific suspend hook so as not to have any unintended consequences for other SoCs supported by this driver. Signed-off-by: Peter Griffin Link: https://lore.kernel.org/r/20250319-exynos-ufs-stability-fixes-v2-7-96722cc2ba1b@linaro.org Reviewed-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/ufs/host/ufs-exynos.c | 10 ++++++++++ drivers/ufs/host/ufs-exynos.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 344bcc8152244..795716f2d84f1 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1656,6 +1656,12 @@ static void exynos_ufs_hibern8_notify(struct ufs_hba *hba, } } +static int gs101_ufs_suspend(struct exynos_ufs *ufs) +{ + hci_writel(ufs, 0 << 0, HCI_GPIO_OUT); + return 0; +} + static int exynos_ufs_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op, enum ufs_notify_change_status status) { @@ -1664,6 +1670,9 @@ static int exynos_ufs_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op, if (status == PRE_CHANGE) return 0; + if (ufs->drv_data->suspend) + ufs->drv_data->suspend(ufs); + if (!ufshcd_is_link_active(hba)) phy_power_off(ufs->phy); @@ -2140,6 +2149,7 @@ static const struct exynos_ufs_drv_data gs101_ufs_drvs = { .pre_link = gs101_ufs_pre_link, .post_link = gs101_ufs_post_link, .pre_pwr_change = gs101_ufs_pre_pwr_change, + .suspend = gs101_ufs_suspend, }; static const struct of_device_id exynos_ufs_of_match[] = { diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h index 1646c4a9bb088..be4e3a2411edb 100644 --- a/drivers/ufs/host/ufs-exynos.h +++ b/drivers/ufs/host/ufs-exynos.h @@ -191,6 +191,7 @@ struct exynos_ufs_drv_data { struct ufs_pa_layer_attr *pwr); int (*pre_hce_enable)(struct exynos_ufs *ufs); int (*post_hce_enable)(struct exynos_ufs *ufs); + int (*suspend)(struct exynos_ufs *ufs); }; struct ufs_phy_time_cfg { -- 2.39.5