From: Alexey Gladkov <legion@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Petr Pavlu <petr.pavlu@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Khalid Aziz <khalid@gonehiking.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-scsi@vger.kernel.org,
Alexey Gladkov <legion@kernel.org>
Subject: [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE
Date: Tue, 27 May 2025 15:15:44 +0200 [thread overview]
Message-ID: <20250527131544.63330-1-legion@kernel.org> (raw)
In-Reply-To: <cover.1748335606.git.legion@kernel.org>
Since MODULE_DEVICE_TABLE no longer depends on whether the module is
built separately or compiled into the kernel, it now makes sense to
always define DEVICE_TABLE. In this case, even if the module is in the
kernel, correct module.builtin.modaliases will be generated.
Suggested-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
drivers/scsi/BusLogic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 8ce2ac9293a3..08e12a3d6703 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -3715,7 +3715,6 @@ static void __exit blogic_exit(void)
__setup("BusLogic=", blogic_setup);
-#ifdef MODULE
/*static const struct pci_device_id blogic_pci_tbl[] = {
{ PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
@@ -3732,7 +3731,6 @@ static const struct pci_device_id blogic_pci_tbl[] = {
{0, },
};
MODULE_DEVICE_TABLE(pci, blogic_pci_tbl);
-#endif
module_init(blogic_init);
module_exit(blogic_exit);
--
2.49.0
next prev parent reply other threads:[~2025-05-27 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1748335606.git.legion@kernel.org>
[not found] ` <628e85f1b7e9d0423a8b83ac3150b3e151c9c4e3.1748335606.git.legion@kernel.org>
2025-05-27 11:28 ` [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary James Bottomley
2025-05-27 11:54 ` Alexey Gladkov
2025-05-27 11:58 ` James Bottomley
2025-05-27 12:58 ` Alexey Gladkov
2025-05-27 14:06 ` [PATCH v4 1/6] scsi: Always define blogic_pci_tbl structure Alexey Gladkov
2025-05-27 13:15 ` Alexey Gladkov [this message]
2025-05-27 13:22 ` [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE James Bottomley
2025-05-27 13:44 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527131544.63330-1-legion@kernel.org \
--to=legion@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=da.gomez@samsung.com \
--cc=khalid@gonehiking.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox