Re: [PATCH 00/10] fallocate: introduce FALLOC_FL_WRITE_ZEROES flag

Martin K. Petersen
2025-06-10T01:47:51Z

Zhang,

> Changes since RFC v4:
> - Rebase codes on 6.16-rc1.
> - Add a new queue_limit flag, and change the write_zeroes_unmap sysfs
> interface to RW mode. User can disable the unmap write zeroes
> operation by writing '0' to it when the operation is slow.
> - Modify the documentation of write_zeroes_unmap sysfs interface as
> Martin suggested.
> - Remove the statx interface.
> - Make the bdev and ext4 don't allow to submit FALLOC_FL_WRITE_ZEROES
> if the block device does not enable the unmap write zeroes operation,
> it should return -EOPNOTSUPP.

This looks OK to me as long as the fs folks agree on the fallocate()
semantics.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

--
Martin K. Petersen