From: Greg KH <gregkh@linuxfoundation.org>
To: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
Cc: liyihang9@huawei.com, James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, linux-kernel-mentees@lists.linux.dev,
shuah@kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: use sysfs_emit() in v3 hw show() functions
Date: Sat, 12 Jul 2025 16:43:09 +0200 [thread overview]
Message-ID: <2025071244-widely-strangely-b24c@gregkh> (raw)
In-Reply-To: <20250712142804.339241-1-khaledelnaggarlinux@gmail.com>
On Sat, Jul 12, 2025 at 05:28:03PM +0300, Khaled Elnaggar wrote:
> Replace scnprintf() with sysfs_emit() in several sysfs show()
> callbacks in hisi_sas_v3_hw.c. This is recommended in
> Documentation/filesystems/sysfs.rst for formatting values returned to
> userspace.
For new users, yes, but what's wrong with these existing calls? They
still work properly, so why change them?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-12 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 14:28 [PATCH] scsi: hisi_sas: use sysfs_emit() in v3 hw show() functions Khaled Elnaggar
2025-07-12 14:43 ` Greg KH [this message]
2025-07-12 15:17 ` Khaled Elnaggar
2025-07-13 17:58 ` Bart Van Assche
2025-07-14 5:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071244-widely-strangely-b24c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=khaledelnaggarlinux@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liyihang9@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox