From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v22 09/14] null_blk: Add the preserves_write_order attribute
Date: Thu, 24 Jul 2025 14:56:58 -0700 [thread overview]
Message-ID: <20250724215703.2910510-10-bvanassche@acm.org> (raw)
In-Reply-To: <20250724215703.2910510-1-bvanassche@acm.org>
Support configuring the BLK_FEAT_ORDERED_HWQ flag in the null_blk driver to
make it easier to test support for this feature flag.
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/block/null_blk/main.c | 4 ++++
drivers/block/null_blk/null_blk.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index aa163ae9b2aa..8ead29140a3e 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -475,6 +475,7 @@ NULLB_DEVICE_ATTR(fua, bool, NULL);
NULLB_DEVICE_ATTR(rotational, bool, NULL);
NULLB_DEVICE_ATTR(badblocks_once, bool, NULL);
NULLB_DEVICE_ATTR(badblocks_partial_io, bool, NULL);
+NULLB_DEVICE_ATTR(preserves_write_order, bool, NULL);
static ssize_t nullb_device_power_show(struct config_item *item, char *page)
{
@@ -613,6 +614,7 @@ static struct configfs_attribute *nullb_device_attrs[] = {
&nullb_device_attr_no_sched,
&nullb_device_attr_poll_queues,
&nullb_device_attr_power,
+ &nullb_device_attr_preserves_write_order,
&nullb_device_attr_queue_mode,
&nullb_device_attr_rotational,
&nullb_device_attr_shared_tag_bitmap,
@@ -1979,6 +1981,8 @@ static int null_add_dev(struct nullb_device *dev)
if (dev->virt_boundary)
lim.virt_boundary_mask = PAGE_SIZE - 1;
null_config_discard(nullb, &lim);
+ if (dev->preserves_write_order)
+ lim.features |= BLK_FEAT_ORDERED_HWQ;
if (dev->zoned) {
rv = null_init_zoned_dev(dev, &lim);
if (rv)
diff --git a/drivers/block/null_blk/null_blk.h b/drivers/block/null_blk/null_blk.h
index 7bb6128dbaaf..08b732cf853f 100644
--- a/drivers/block/null_blk/null_blk.h
+++ b/drivers/block/null_blk/null_blk.h
@@ -110,6 +110,7 @@ struct nullb_device {
bool shared_tag_bitmap; /* use hostwide shared tags */
bool fua; /* Support FUA */
bool rotational; /* Fake rotational device */
+ bool preserves_write_order;
};
struct nullb {
next prev parent reply other threads:[~2025-07-24 21:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 21:56 [PATCH v22 00/14] Improve write performance for zoned UFS devices Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 01/14] block: Support block devices that preserve the order of write requests Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 02/14] blk-mq: Always insert sequential zoned writes into a software queue Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 03/14] blk-mq: Restore the zone write order when requeuing Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 04/14] blk-zoned: Add an argument to blk_zone_plug_bio() Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 05/14] blk-zoned: Split an if-statement Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 06/14] blk-zoned: Move code from disk_zone_wplug_add_bio() into its caller Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 07/14] blk-zoned: Introduce a loop in blk_zone_wplug_bio_work() Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 08/14] blk-zoned: Support pipelining of zoned writes Bart Van Assche
2025-07-24 21:56 ` Bart Van Assche [this message]
2025-07-24 21:56 ` [PATCH v22 10/14] scsi: core: Retry unaligned " Bart Van Assche
2025-07-24 21:57 ` [PATCH v22 11/14] scsi: sd: Increase retry count for " Bart Van Assche
2025-07-24 21:57 ` [PATCH v22 12/14] scsi: scsi_debug: Add the preserves_write_order module parameter Bart Van Assche
2025-07-24 21:57 ` [PATCH v22 13/14] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2025-07-24 21:57 ` [PATCH v22 14/14] ufs: core: Inform the block layer about write ordering Bart Van Assche
2025-08-01 8:04 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724215703.2910510-10-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).