From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v22 11/14] scsi: sd: Increase retry count for zoned writes
Date: Thu, 24 Jul 2025 14:57:00 -0700 [thread overview]
Message-ID: <20250724215703.2910510-12-bvanassche@acm.org> (raw)
In-Reply-To: <20250724215703.2910510-1-bvanassche@acm.org>
If the write order is preserved, increase the number of retries for
write commands sent to a sequential zone to the maximum number of
outstanding commands because in the worst case the number of times
reordered zoned writes have to be retried is (number of outstanding
writes per sequential zone) - 1.
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/sd.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index eeaa6af294b8..587d91a9e10c 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1404,6 +1404,13 @@ static blk_status_t sd_setup_read_write_cmnd(struct scsi_cmnd *cmd)
cmd->transfersize = sdp->sector_size;
cmd->underflow = nr_blocks << 9;
cmd->allowed = sdkp->max_retries;
+ /*
+ * Increase the number of allowed retries for zoned writes if the driver
+ * preserves the command order.
+ */
+ if (rq->q->limits.features & BLK_FEAT_ORDERED_HWQ &&
+ blk_rq_is_seq_zoned_write(rq))
+ cmd->allowed += rq->q->nr_requests;
cmd->sdb.length = nr_blocks * sdp->sector_size;
SCSI_LOG_HLQUEUE(1,
next prev parent reply other threads:[~2025-07-24 21:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 21:56 [PATCH v22 00/14] Improve write performance for zoned UFS devices Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 01/14] block: Support block devices that preserve the order of write requests Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 02/14] blk-mq: Always insert sequential zoned writes into a software queue Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 03/14] blk-mq: Restore the zone write order when requeuing Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 04/14] blk-zoned: Add an argument to blk_zone_plug_bio() Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 05/14] blk-zoned: Split an if-statement Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 06/14] blk-zoned: Move code from disk_zone_wplug_add_bio() into its caller Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 07/14] blk-zoned: Introduce a loop in blk_zone_wplug_bio_work() Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 08/14] blk-zoned: Support pipelining of zoned writes Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 09/14] null_blk: Add the preserves_write_order attribute Bart Van Assche
2025-07-24 21:56 ` [PATCH v22 10/14] scsi: core: Retry unaligned zoned writes Bart Van Assche
2025-07-24 21:57 ` Bart Van Assche [this message]
2025-07-24 21:57 ` [PATCH v22 12/14] scsi: scsi_debug: Add the preserves_write_order module parameter Bart Van Assche
2025-07-24 21:57 ` [PATCH v22 13/14] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2025-07-24 21:57 ` [PATCH v22 14/14] ufs: core: Inform the block layer about write ordering Bart Van Assche
2025-08-01 8:04 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724215703.2910510-12-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).