From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E9419066B for ; Fri, 25 Jul 2025 02:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753408847; cv=none; b=QFfEJ92gtI1qPB6KBgNA3Ke1hFD8EaC59bkAvv0m1bEIkJT/jR+wYdSAnx4EIMAk63gq70NtK3sa/dixrVWWtMqWBBETwMMNAXoaZZrw9oHuHfLUSeTe9mRMZJIzRdsgcPK59D3UqdiyOsGdgJG7LbhWOAW9uWcJ98NJfgZqKH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753408847; c=relaxed/simple; bh=LLfmZiQEoDSOrlBZWiKoPbKJAiD+2Gio8rdnOpFcVdU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AS7CVQVVV487NYiGHMEiY0UW7ETos4IvSm/zCDwi0snaXUpNzvXEfU/UAUxZJZkcjFIGBwS4j4b69+6A3xKvuRajGBRAK2Zm/xcbLzNMtRtlDuVQqxwhq0iRC03K+eAhdyhwQJUcAh7r+8E0m0C9YBNQpHv+W2ziqISf8H8jolA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K6mbD69k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K6mbD69k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AC6BC4CEF5; Fri, 25 Jul 2025 02:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753408847; bh=LLfmZiQEoDSOrlBZWiKoPbKJAiD+2Gio8rdnOpFcVdU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=K6mbD69kQ3vpuONI3YlOtlQ0R1XqrXwROoKPIMzVjMJzgrVJsrU/EL31KTImYdD3v j/vt08NGCfjJK3JSq6hfcAalJWkcHAE/RyMtE4FVqMO07bF/QnRBsPdJ8uap0fMQGd aR0xvHXX76LdmGQn9RLds/lY2IYL2o57Y/MxAJfe6Fq8d/knZUZmYlJ+94/7hIejrf RpY2dgVoj7yGw453xPo43nxtZcXCHBibG3fuwU2gEj/5GZobe4LbBe7uPX/IozfmOS rUWFzhn+cz/pkUNJ55A04tZ4Bo6zlbO3zQVJ9uTXt4a5t/XeQzL774WA4a3XW+mPs2 V3h0XeqL5nh7g== From: Damien Le Moal To: linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry Subject: [PATCH v4 2/5] scsi: libsas: Simplify sas_ata_wait_eh() Date: Fri, 25 Jul 2025 10:58:15 +0900 Message-ID: <20250725015818.171252-3-dlemoal@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250725015818.171252-1-dlemoal@kernel.org> References: <20250725015818.171252-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify the code of sas_ata_wait_eh(), removing the local variable ap for the pointer to the device ata_port structure. The test using dev_is_sata() is also removed as all call sites of this function check if the device is a SATA one before calling this function. Signed-off-by: Damien Le Moal Reviewed-by: John Garry --- drivers/scsi/libsas/sas_ata.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 7b4e7a61965a..2cbf38b18c5c 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -927,13 +927,7 @@ EXPORT_SYMBOL_GPL(sas_ata_schedule_reset); void sas_ata_wait_eh(struct domain_device *dev) { - struct ata_port *ap; - - if (!dev_is_sata(dev)) - return; - - ap = dev->sata_dev.ap; - ata_port_wait_eh(ap); + ata_port_wait_eh(dev->sata_dev.ap); } void sas_ata_device_link_abort(struct domain_device *device, bool force_reset) -- 2.50.1