Re: [PATCH v2 2/3] scsi: target: Create and use macro helpers for per CPU stats

[Dmitry Bogdanov <d.bogdanov@yadro.com>]

On Mon, Sep 08, 2025 at 06:05:55PM -0500, Mike Christie wrote:
> 
> This creates some macros to reduce code duplication for when we handle
> per CPU stats. It them converts the existing LUN and auth cases.
> 
> Note: This is similar to percpu_counters but they only support s64 since
> they are also used for non-stat counters where you need to handle/prevent
> rollover more gracefully. Our use is just for stats where the spec
> defines u64 use plus we already have some files exporting u64 values so
> it's not possible to directly use percpu_counters.
> 
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
>  drivers/target/target_core_stat.c | 197 +++++++++---------------------
>  1 file changed, 61 insertions(+), 136 deletions(-)
> 


Thanks, that you agreed create such macros.

Reviewed-by: Dmitry Bogdanov <d.bogdanov@yadro.com>