From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96F9419FA8D for ; Sun, 5 Oct 2025 19:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759691171; cv=none; b=FqoQ6Qi8t1cZy5M2sDiRxn7Ln7081kcKRGIPXH79uNRnWCeXk8GammxFPvLJT+T8b6Y+LxcUmlMYh5AYC5LT1ELjP5oVf8pDWHz2x3TUXTWHcbl+2ba3HdM9ZqpfG5aBO6ckfvKLS+xtGvTTc06xjvlOa7ISE3n0zvbEboyF7q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759691171; c=relaxed/simple; bh=EKt1fHoKmILVRWaVPU0zfxrWGRWt3ZKHxPM2f8AtEN0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Je2SQPBPNdK0RkmCui7bsVgfitTut5fmNdquWxOpr6OABFFNkgsvOVF5rlW2fJHy1zpkBiDWtca4uv7qgDYbuqKJMglH7wqUbqAsA8RW53msmEhtqLQ+zyqNvPx2ZeXcXTi2cpiGRiTBQyOETjeftk7ywuIH8CmiHZ0HxloMKrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=QWOchw9r; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="QWOchw9r" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3117E240029 for ; Sun, 5 Oct 2025 21:06:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1759691168; bh=b8JRyvvgoYPi6SHn/BleoYI91JZ0LX+UG4+W95ocuHU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:Autocrypt:OpenPGP:From; b=QWOchw9rdEDNq9OLuNo93ifTbO1+yOL4fpqr5wzZwY/KaFJOlCnPEzILR8bYg1MYV puu8VdyWvCH3cmQAohTfsLX03nQmNBJawtvcYkG4qWEY0HbQy4GjrCGiGq0CzTZCHv kxfAQDzc3I5XGxvsGua/c0zA1wozvzwEKWeLtqQ/pcHh8hxrHFOcjdqBFwk8OivjpB YgHdRlB1vSri6Q+XOKHofBRLPPk/JmEY9NaXixCvlBZ3Tam8DjuuJz5nKbGQF87GPX EPklJIgrDJB59dbNKgPYFtlvLZkFNt4I5UyvMw/8daPqcfp2fdqGwQtwGm/9sP9P55 xq1/HVBsLKeDg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4cfsLl2Rs0z9rxG; Sun, 5 Oct 2025 21:06:07 +0200 (CEST) From: Markus Probst To: Damien Le Moal , Niklas Cassel , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Probst Subject: [PATCH 2/2] Power on ata ports defined in ACPI before probing ports Date: Sun, 05 Oct 2025 19:06:07 +0000 Message-ID: <20251005190559.1472308-2-markus.probst@posteo.de> In-Reply-To: <20251005190559.1472308-1-markus.probst@posteo.de> References: <8c3cb28c57462f9665b08fdaa022e6abc57fcd9e.camel@posteo.de> <20251005190559.1472308-1-markus.probst@posteo.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt some devices (for example every synology nas with "deep sleep" support) have the ability to power on and off each ata port individually. This turns the specific port on, if power manageable in acpi, before probing it. This can later be extended to power down the ata ports (removing power from a disk) while the disk is spin down. Signed-off-by: Markus Probst --- drivers/ata/libata-acpi.c | 68 +++++++++++++++++++++++++++++++++++++++ drivers/ata/libata-core.c | 21 ++++++++++++ drivers/ata/libata-scsi.c | 1 + drivers/ata/libata.h | 4 +++ include/linux/libata.h | 1 + 5 files changed, 95 insertions(+) diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index f2140fc06ba0..891b59bfe29f 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -245,6 +245,74 @@ void ata_acpi_bind_dev(struct ata_device *dev) ata_acpi_dev_uevent); } +/** + * ata_acpi_dev_manage_restart - if the disk should be stopped (spin down) on system restart. + * @dev: target ATA device + * + * RETURNS: + * true if the disk should be stopped, otherwise false + */ +bool ata_acpi_dev_manage_restart(struct ata_device *dev) +{ + // If the device is power manageable and we assume the disk loses power on reboot. + if (dev->link->ap->flags & ATA_FLAG_ACPI_SATA) { + if (!is_acpi_device_node(dev->tdev.fwnode)) + return false; + return acpi_bus_power_manageable(ACPI_HANDLE(&dev->tdev)); + } + + if (!is_acpi_device_node(dev->link->ap->tdev.fwnode)) + return false; + return acpi_bus_power_manageable(ACPI_HANDLE(&dev->link->ap->tdev)); +} + +/** + * ata_acpi_port_set_power_state - set the power state of the ata port + * @ap: target ATA port + * + * This function is called at the begin of ata_port_probe. + */ +void ata_acpi_port_set_power_state(struct ata_port *ap, bool enable) +{ + acpi_handle handle; + unsigned char state; + int i; + + if (libata_noacpi) + return; + + if (enable) + state = ACPI_STATE_D0; + else + state = ACPI_STATE_D3_COLD; + + if (ap->flags & ATA_FLAG_ACPI_SATA) { + for (i = 0; i < ATA_MAX_DEVICES; i++) { + if (!is_acpi_device_node(ap->link.device[i].tdev.fwnode)) + continue; + handle = ACPI_HANDLE(&ap->link.device[i].tdev); + if (!acpi_bus_power_manageable(handle)) + continue; + if (!acpi_bus_set_power(handle, state)) + ata_dev_info(&ap->link.device[i], "acpi: power was set to %d\n", + enable); + else + ata_dev_info(&ap->link.device[i], "acpi: power failed to be set\n"); + } + } else { + if (!is_acpi_device_node(ap->tdev.fwnode)) + return; + handle = ACPI_HANDLE(&ap->tdev); + if (!acpi_bus_power_manageable(handle)) + return; + + if (!acpi_bus_set_power(handle, state)) + ata_port_info(ap, "acpi: power was set to %d\n", enable); + else + ata_port_info(ap, "acpi: power failed to be set\n"); + } +} + /** * ata_acpi_dissociate - dissociate ATA host from ACPI objects * @host: target ATA host diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index ff53f5f029b4..a52b916af14c 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5899,11 +5899,32 @@ void ata_host_init(struct ata_host *host, struct device *dev, } EXPORT_SYMBOL_GPL(ata_host_init); +static inline void ata_port_set_power_state(struct ata_port *ap, bool enable) +{ + ata_acpi_port_set_power_state(ap, enable); + // Maybe add a way with device tree and regulators too? +} + +/** + * ata_dev_manage_restart - if the disk should be stopped (spin down) on system restart. + * @dev: target ATA device + * + * RETURNS: + * true if the disk should be stopped, otherwise false + */ +bool ata_dev_manage_restart(struct ata_device *dev) +{ + return ata_acpi_dev_manage_restart(dev); +} +EXPORT_SYMBOL_GPL(ata_dev_manage_restart); + void ata_port_probe(struct ata_port *ap) { struct ata_eh_info *ehi = &ap->link.eh_info; unsigned long flags; + ata_port_set_power_state(ap, true); + /* kick EH for boot probing */ spin_lock_irqsave(ap->lock, flags); diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 2ded5e476d6e..52297d9e3dc2 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1095,6 +1095,7 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct queue_limits *lim, */ sdev->manage_runtime_start_stop = 1; sdev->manage_shutdown = 1; + sdev->manage_restart = ata_dev_manage_restart(dev); sdev->force_runtime_start_on_system_start = 1; } diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h index e5b977a8d3e1..28cb652d99bc 100644 --- a/drivers/ata/libata.h +++ b/drivers/ata/libata.h @@ -130,6 +130,8 @@ extern void ata_acpi_on_disable(struct ata_device *dev); extern void ata_acpi_set_state(struct ata_port *ap, pm_message_t state); extern void ata_acpi_bind_port(struct ata_port *ap); extern void ata_acpi_bind_dev(struct ata_device *dev); +extern void ata_acpi_port_set_power_state(struct ata_port *ap, bool enable); +extern bool ata_acpi_dev_manage_restart(struct ata_device *dev); extern acpi_handle ata_dev_acpi_handle(struct ata_device *dev); #else static inline void ata_acpi_dissociate(struct ata_host *host) { } @@ -140,6 +142,8 @@ static inline void ata_acpi_set_state(struct ata_port *ap, pm_message_t state) { } static inline void ata_acpi_bind_port(struct ata_port *ap) {} static inline void ata_acpi_bind_dev(struct ata_device *dev) {} +static inline void ata_acpi_port_set_power_state(struct ata_port *ap, bool enable) {} +static inline bool ata_acpi_dev_manage_restart(struct ata_device *dev) { return false; } #endif /* libata-scsi.c */ diff --git a/include/linux/libata.h b/include/linux/libata.h index 0620dd67369f..af5974e91e1d 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1302,6 +1302,7 @@ extern int sata_link_debounce(struct ata_link *link, extern int sata_link_scr_lpm(struct ata_link *link, enum ata_lpm_policy policy, bool spm_wakeup); extern int ata_slave_link_init(struct ata_port *ap); +extern bool ata_dev_manage_restart(struct ata_device *dev); extern void ata_port_probe(struct ata_port *ap); extern struct ata_port *ata_port_alloc(struct ata_host *host); extern void ata_port_free(struct ata_port *ap); -- 2.49.1