From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3D6230C371 for ; Tue, 14 Oct 2025 13:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760447891; cv=none; b=iApAkD8nniTlF5ZmwkVHUVJwBZhwrKZlgkF+YhY2hApYeDIh7qwNlXPxQHQy5ln43BSYzQhnHBY8VcDXS124zLZpUG4HdHf6gLysZRNWCDAZCAjxSLRFPD84wPSJNq+drX6zqd7eJSWSRWYe2QkX1Kg8SBwTdST3L8Ps3GOTMxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760447891; c=relaxed/simple; bh=a4U9kx+Xi94Kq6OcyaZHLd8HYR6/Nns88uhffwYgL80=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RSPa60/9VgQ9GiflHueOTFaP8CGwmdLBUu1IuBxeQKpHiIpfGtrnk8tLqOpkweNvaCJIQveQzs9qsfF7rsoa5Js/Uo6NNheOZPYDdxdnWCTZAXBDkLVm0gg8LKU81HsfLwytz7aiQ/QPW8ODCO3ENxb89MC/QGlivQnOg7mcECo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=nVpg5dXg; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="nVpg5dXg" X-UUID: 35cec0cca90011f0ae1e63ff8927bad3-20251014 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=0v/CBd1rmPyG88zln9xhPVoHM485BZhnHYxuMKXiFXE=; b=nVpg5dXgCG08lKzjCVgj8dPRlxJCowM2jQHQ1LFC5+0s6A2qpuvigUG+Au2ZhhA23M9WwLeptmnjR5HJVW90NAutQBsg1eip3DRJY4+iQ/Yx80uXOR1QKh4PY+7EQuIiJQd2tAd0kXvXRaw/ambu4t3twlOvXt6yhOTUDR2uOcM=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.6,REQID:63090723-ef0a-49ff-9e88-a25094724279,IP:0,UR L:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-25 X-CID-META: VersionHash:a9d874c,CLOUDID:d0670c51-c509-4cf3-8dc0-fcdaad49a6d3,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|888|898,TC:-5,Content: 0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 35cec0cca90011f0ae1e63ff8927bad3-20251014 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 760664814; Tue, 14 Oct 2025 21:18:01 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Tue, 14 Oct 2025 21:18:00 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Tue, 14 Oct 2025 21:18:00 +0800 From: To: , CC: , , , , , , , , , , , , , , Subject: [PATCH v1 2/2] ufs: core: support dumping CQ entry in MCQ Mode Date: Tue, 14 Oct 2025 21:15:56 +0800 Message-ID: <20251014131758.270324-3-peter.wang@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20251014131758.270324-1-peter.wang@mediatek.com> References: <20251014131758.270324-1-peter.wang@mediatek.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N From: Peter Wang Enhance the ufshcd_print_tr function to support dumping completion queue (CQ) entries in MCQ mode when an error occurs. This addition provides more detailed debugging information by including the CQ entry data in the error logs, aiding in the diagnosis of issues in MCQ mode. Signed-off-by: Peter Wang --- drivers/ufs/core/ufshcd.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index d779cc777a17..b90500126b35 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -599,7 +599,8 @@ static void ufshcd_print_evt_hist(struct ufs_hba *hba) } static -void ufshcd_print_tr(struct ufs_hba *hba, int tag, bool pr_prdt) +void ufshcd_print_tr(struct ufs_hba *hba, struct cq_entry *cqe, + int tag, bool pr_prdt) { const struct ufshcd_lrb *lrbp; int prdt_length; @@ -618,6 +619,8 @@ void ufshcd_print_tr(struct ufs_hba *hba, int tag, bool pr_prdt) ufshcd_hex_dump("UPIU TRD: ", lrbp->utr_descriptor_ptr, sizeof(struct utp_transfer_req_desc)); + if (cqe) + ufshcd_hex_dump("UPIU CQE: ", cqe, sizeof(struct cq_entry)); dev_err(hba->dev, "UPIU[%d] - Request UPIU phys@0x%llx\n", tag, (u64)lrbp->ucd_req_dma_addr); ufshcd_hex_dump("UPIU REQ: ", lrbp->ucd_req_ptr, @@ -648,7 +651,7 @@ static bool ufshcd_print_tr_iter(struct request *req, void *priv) struct Scsi_Host *shost = sdev->host; struct ufs_hba *hba = shost_priv(shost); - ufshcd_print_tr(hba, req->tag, *(bool *)priv); + ufshcd_print_tr(hba, NULL, req->tag, *(bool *)priv); return true; } @@ -5536,7 +5539,7 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp, if ((host_byte(result) != DID_OK) && (host_byte(result) != DID_REQUEUE) && !hba->silence_err_logs) - ufshcd_print_tr(hba, lrbp->task_tag, true); + ufshcd_print_tr(hba, cqe, lrbp->task_tag, true); return result; } @@ -7763,9 +7766,9 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) ufshcd_print_evt_hist(hba); ufshcd_print_host_state(hba); ufshcd_print_pwr_info(hba); - ufshcd_print_tr(hba, tag, true); + ufshcd_print_tr(hba, NULL, tag, true); } else { - ufshcd_print_tr(hba, tag, false); + ufshcd_print_tr(hba, NULL, tag, false); } hba->req_abort_count++; -- 2.45.2