linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
	Avri Altman <avri.altman@sandisk.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Peter Wang <peter.wang@mediatek.com>,
	"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
	Alok Tiwari <alok.a.tiwari@oracle.com>,
	Chenyuan Yang <chenyuan0y@gmail.com>,
	"ping.gao" <ping.gao@samsung.com>
Subject: [PATCH v6 08/28] ufs: core: Move an assignment in ufshcd_mcq_process_cqe()
Date: Tue, 14 Oct 2025 13:15:50 -0700	[thread overview]
Message-ID: <20251014201707.3396650-9-bvanassche@acm.org> (raw)
In-Reply-To: <20251014201707.3396650-1-bvanassche@acm.org>

Prepare for introducing a WARN_ON_ONCE() call in ufshcd_mcq_get_tag() if
the tag lookup fails.

Reviewed-by: Avri Altman <avri.altman@sandisk.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/ufs/core/ufs-mcq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
index c9bdd4140fd0..8780be79a0f8 100644
--- a/drivers/ufs/core/ufs-mcq.c
+++ b/drivers/ufs/core/ufs-mcq.c
@@ -307,9 +307,10 @@ static void ufshcd_mcq_process_cqe(struct ufs_hba *hba,
 				   struct ufs_hw_queue *hwq)
 {
 	struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);
-	int tag = ufshcd_mcq_get_tag(hba, cqe);
 
 	if (cqe->command_desc_base_addr) {
+		int tag = ufshcd_mcq_get_tag(hba, cqe);
+
 		ufshcd_compl_one_cqe(hba, tag, cqe);
 		/* After processed the cqe, mark it empty (invalid) entry */
 		cqe->command_desc_base_addr = 0;

  parent reply	other threads:[~2025-10-14 20:18 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 20:15 [PATCH v6 00/28] Optimize the hot path in the UFS driver Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 01/28] scsi: core: Support allocating reserved commands Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 02/28] scsi: core: Move two statements Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 03/28] scsi: core: Make the budget map optional Bart Van Assche
2025-10-16  6:06   ` Hannes Reinecke
2025-10-22  8:29   ` John Garry
2025-10-22 17:23     ` Bart Van Assche
2025-10-23 10:02       ` John Garry
2025-10-14 20:15 ` [PATCH v6 04/28] scsi: core: Support allocating a pseudo SCSI device Bart Van Assche
2025-10-20 11:10   ` John Garry
2025-10-20 16:10     ` Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 05/28] scsi: core: Introduce .queue_reserved_command() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 06/28] scsi: core: Add scsi_{get,put}_internal_cmd() helpers Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 07/28] scsi_debug: Abort SCSI commands via an internal command Bart Van Assche
2025-10-22  8:46   ` John Garry
2025-10-23 16:19     ` Bart Van Assche
2025-10-14 20:15 ` Bart Van Assche [this message]
2025-10-14 20:15 ` [PATCH v6 09/28] ufs: core: Change the type of one ufshcd_add_cmd_upiu_trace() argument Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 10/28] ufs: core: Only call ufshcd_add_command_trace() for SCSI commands Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 11/28] ufs: core: Change the type of one ufshcd_add_command_trace() argument Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 12/28] ufs: core: Change the type of one ufshcd_send_command() argument Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 13/28] ufs: core: Only call ufshcd_should_inform_monitor() for SCSI commands Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 14/28] ufs: core: Change the monitor function argument types Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 15/28] ufs: core: Rework ufshcd_mcq_compl_pending_transfer() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 16/28] ufs: core: Rework ufshcd_eh_device_reset_handler() Bart Van Assche
2025-10-14 20:15 ` [PATCH v6 17/28] ufs: core: Rework the SCSI host queue depth calculation code Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 18/28] ufs: core: Allocate the SCSI host earlier Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 19/28] ufs: core: Call ufshcd_init_lrb() later Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 20/28] ufs: core: Use hba->reserved_slot Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 21/28] ufs: core: Make the reserved slot a reserved request Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 22/28] ufs: core: Do not clear driver-private command data Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 23/28] ufs: core: Optimize the hot path Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 24/28] ufs: core: Pass a SCSI pointer instead of an LRB pointer Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 25/28] ufs: core: Remove the ufshcd_lrb task_tag member Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 26/28] ufs: core: Make blk_mq_tagset_busy_iter() skip reserved requests Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 27/28] ufs: core: Move code out of ufshcd_wait_for_dev_cmd() Bart Van Assche
2025-10-14 20:16 ` [PATCH v6 28/28] ufs: core: Switch to scsi_get_internal_cmd() Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251014201707.3396650-9-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=avri.altman@sandisk.com \
    --cc=chenyuan0y@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=ping.gao@samsung.com \
    --cc=quic_nguyenb@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).