From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Avri Altman <avri.altman@sandisk.com>,
Peter Wang <peter.wang@mediatek.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bean Huo <beanhuo@micron.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH v7 09/28] ufs: core: Change the type of one ufshcd_add_cmd_upiu_trace() argument
Date: Thu, 30 Oct 2025 12:36:08 -0700 [thread overview]
Message-ID: <20251030193720.871635-10-bvanassche@acm.org> (raw)
In-Reply-To: <20251030193720.871635-1-bvanassche@acm.org>
Change the 'tag' argument into an LRB pointer. This patch prepares for the
removal of the hba->lrb[] array.
Reviewed-by: Avri Altman <avri.altman@sandisk.com>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index fc4d1b6576dc..cdb8147fceb9 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -403,10 +403,11 @@ static void ufshcd_configure_wb(struct ufs_hba *hba)
ufshcd_wb_toggle_buf_flush(hba, true);
}
-static void ufshcd_add_cmd_upiu_trace(struct ufs_hba *hba, unsigned int tag,
+static void ufshcd_add_cmd_upiu_trace(struct ufs_hba *hba,
+ struct ufshcd_lrb *lrb,
enum ufs_trace_str_t str_t)
{
- struct utp_upiu_req *rq = hba->lrb[tag].ucd_req_ptr;
+ struct utp_upiu_req *rq = lrb->ucd_req_ptr;
struct utp_upiu_header *header;
if (!trace_ufshcd_upiu_enabled())
@@ -415,7 +416,7 @@ static void ufshcd_add_cmd_upiu_trace(struct ufs_hba *hba, unsigned int tag,
if (str_t == UFS_CMD_SEND)
header = &rq->header;
else
- header = &hba->lrb[tag].ucd_rsp_ptr->header;
+ header = &lrb->ucd_rsp_ptr->header;
trace_ufshcd_upiu(hba, str_t, header, &rq->sc.cdb,
UFS_TSF_CDB);
@@ -489,7 +490,7 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag,
return;
/* trace UPIU also */
- ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
+ ufshcd_add_cmd_upiu_trace(hba, lrbp, str_t);
if (!trace_ufshcd_command_enabled())
return;
next prev parent reply other threads:[~2025-10-30 19:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 19:35 [PATCH v7 00/28] Optimize the hot path in the UFS driver Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 01/28] scsi: core: Support allocating reserved commands Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 02/28] scsi: core: Move two statements Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 03/28] scsi: core: Make the budget map optional Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 04/28] scsi: core: Support allocating a pseudo SCSI device Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 05/28] scsi: core: Introduce .queue_reserved_command() Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 06/28] scsi: core: Add scsi_{get,put}_internal_cmd() helpers Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 07/28] scsi_debug: Abort SCSI commands via an internal command Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 08/28] ufs: core: Move an assignment in ufshcd_mcq_process_cqe() Bart Van Assche
2025-10-30 19:36 ` Bart Van Assche [this message]
2025-10-30 19:36 ` [PATCH v7 10/28] ufs: core: Only call ufshcd_add_command_trace() for SCSI commands Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 11/28] ufs: core: Change the type of one ufshcd_add_command_trace() argument Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 12/28] ufs: core: Change the type of one ufshcd_send_command() argument Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 13/28] ufs: core: Only call ufshcd_should_inform_monitor() for SCSI commands Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 14/28] ufs: core: Change the monitor function argument types Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 15/28] ufs: core: Rework ufshcd_mcq_compl_pending_transfer() Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 16/28] ufs: core: Rework ufshcd_eh_device_reset_handler() Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 17/28] ufs: core: Rework the SCSI host queue depth calculation code Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 18/28] ufs: core: Allocate the SCSI host earlier Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 19/28] ufs: core: Call ufshcd_init_lrb() later Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 20/28] ufs: core: Use hba->reserved_slot Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 21/28] ufs: core: Make the reserved slot a reserved request Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 22/28] ufs: core: Do not clear driver-private command data Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 23/28] ufs: core: Optimize the hot path Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 24/28] ufs: core: Pass a SCSI pointer instead of an LRB pointer Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 25/28] ufs: core: Remove the ufshcd_lrb task_tag member Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 26/28] ufs: core: Make blk_mq_tagset_busy_iter() skip reserved requests Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 27/28] ufs: core: Move code out of ufshcd_wait_for_dev_cmd() Bart Van Assche
2025-10-30 19:36 ` [PATCH v7 28/28] ufs: core: Switch to scsi_get_internal_cmd() Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030193720.871635-10-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@sandisk.com \
--cc=beanhuo@micron.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox