public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org,
	Karan Tilak Kumar <kartilak@cisco.com>,
	Sesidhar Baddela <sebaddel@cisco.com>,
	Satish Kharat <satishkh@cisco.com>,
	Hannes Reinecke <hare@kernel.org>
Subject: [PATCH 3/4] fnic: missing initialisation for wq_copy_base
Date: Tue,  4 Nov 2025 11:04:23 +0100	[thread overview]
Message-ID: <20251104100424.8215-4-hare@kernel.org> (raw)
In-Reply-To: <20251104100424.8215-1-hare@kernel.org>

With the conversion to multiqueue the 'wq_copy_base' value were left
uninitialized for MSI and INTx interrupts, causing the driver to issue
a message 'FCPIO_SUCCESS icmnd completion on the wrong queue' and finally
running out of command tags as the completions would be accounted on
the wrong queue.

Fixes: 8a8449ca5e33 ("scsi: fnic: Modify ISRs to support multiqueue (MQ)")

Signed-off-by: Hannes Reinecke <hare@kernel.org>
---
 drivers/scsi/fnic/fnic_isr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi/fnic/fnic_isr.c
index 7ed50b11afa6..e16b76d537e8 100644
--- a/drivers/scsi/fnic/fnic_isr.c
+++ b/drivers/scsi/fnic/fnic_isr.c
@@ -350,6 +350,7 @@ int fnic_set_intr_mode(struct fnic *fnic)
 		fnic->cq_count = 3;
 		fnic->intr_count = 1;
 		fnic->err_intr_offset = 0;
+		fnic->copy_wq_base = fnic->rq_count + fnic->raw_wq_count;
 
 		FNIC_ISR_DBG(KERN_DEBUG, fnic->host, fnic->fnic_num,
 			     "Using MSI Interrupts\n");
@@ -376,6 +377,7 @@ int fnic_set_intr_mode(struct fnic *fnic)
 		fnic->wq_copy_count = 1;
 		fnic->cq_count = 3;
 		fnic->intr_count = 3;
+		fnic->copy_wq_base = fnic->rq_count + fnic->raw_wq_count;
 
 		FNIC_ISR_DBG(KERN_DEBUG, fnic->host, fnic->fnic_num,
 			     "Using Legacy Interrupts\n");
-- 
2.43.0


  parent reply	other threads:[~2025-11-04 10:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 10:04 [PATCH 0/4] fnic: fixup INTx and MSI interrupt modes Hannes Reinecke
2025-11-04 10:04 ` [PATCH 1/4] fnic: use resulting interrupt mode during configuration Hannes Reinecke
2025-11-04 23:17   ` Karan Tilak Kumar (kartilak)
2025-11-06 21:56   ` Karan Tilak Kumar (kartilak)
2025-11-04 10:04 ` [PATCH 2/4] fnic: correctly initialize 'fnic->name' Hannes Reinecke
2025-11-04 23:18   ` Karan Tilak Kumar (kartilak)
2025-11-06 21:57   ` Karan Tilak Kumar (kartilak)
2025-11-04 10:04 ` Hannes Reinecke [this message]
2025-11-04 23:19   ` [PATCH 3/4] fnic: missing initialisation for wq_copy_base Karan Tilak Kumar (kartilak)
2025-11-06 22:00   ` Karan Tilak Kumar (kartilak)
2025-11-04 10:04 ` [PATCH 4/4] fnic: make interrupt mode configurable Hannes Reinecke
2025-11-04 23:21   ` Karan Tilak Kumar (kartilak)
2025-11-06 22:09   ` Karan Tilak Kumar (kartilak)
2025-11-07  8:29     ` Hannes Reinecke
2025-11-07 22:23       ` Karan Tilak Kumar (kartilak)
2026-01-14 17:02         ` Karan Tilak Kumar (kartilak)
2026-01-23 18:21           ` Lee Duncan
2026-01-23 18:37             ` Karan Tilak Kumar (kartilak)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104100424.8215-4-hare@kernel.org \
    --to=hare@kernel.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=kartilak@cisco.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox