From: Ranjan Kumar <ranjan.kumar@broadcom.com>
To: linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Cc: sathya.prakash@broadcom.com, sumit.saxena@broadcom.com,
chandrakanth.patil@broadcom.com, prayas.patel@broadcom.com,
Ranjan Kumar <ranjan.kumar@broadcom.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH v2 1/6] mpt3sas: Added no_turs flag to device unblock logic
Date: Thu, 13 Nov 2025 21:07:05 +0530 [thread overview]
Message-ID: <20251113153712.31850-2-ranjan.kumar@broadcom.com> (raw)
In-Reply-To: <20251113153712.31850-1-ranjan.kumar@broadcom.com>
Add a "no_turs" flag to _scsih_ublock_io_all_device() to
optionally skip TEST UNIT READY (TUR) checks while
unblocking devices. This is used after broadcast events
where sending TURs is not required.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510310216.gerpzbxP-lkp@intel.com/
Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 7092d0debef3..013b10348ec4 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -3825,11 +3825,12 @@ _scsih_internal_device_unblock(struct scsi_device *sdev,
/**
* _scsih_ublock_io_all_device - unblock every device
* @ioc: per adapter object
+ * @no_turs: flag to disable TEST UNIT READY checks during device unblocking
*
* change the device state from block to running
*/
static void
-_scsih_ublock_io_all_device(struct MPT3SAS_ADAPTER *ioc)
+_scsih_ublock_io_all_device(struct MPT3SAS_ADAPTER *ioc, u8 no_turs)
{
struct MPT3SAS_DEVICE *sas_device_priv_data;
struct scsi_device *sdev;
@@ -3841,6 +3842,13 @@ _scsih_ublock_io_all_device(struct MPT3SAS_ADAPTER *ioc)
if (!sas_device_priv_data->block)
continue;
+ if (no_turs) {
+ sdev_printk(KERN_WARNING, sdev, "device_unblocked handle(0x%04x)\n",
+ sas_device_priv_data->sas_target->handle);
+ _scsih_internal_device_unblock(sdev, sas_device_priv_data);
+ continue;
+ }
+
dewtprintk(ioc, sdev_printk(KERN_INFO, sdev,
"device_running, handle(0x%04x)\n",
sas_device_priv_data->sas_target->handle));
@@ -8810,7 +8818,7 @@ _scsih_sas_broadcast_primitive_event(struct MPT3SAS_ADAPTER *ioc,
ioc->broadcast_aen_busy = 0;
if (!ioc->shost_recovery)
- _scsih_ublock_io_all_device(ioc);
+ _scsih_ublock_io_all_device(ioc, 1);
mutex_unlock(&ioc->tm_cmds.mutex);
}
@@ -10344,7 +10352,7 @@ _scsih_remove_unresponding_devices(struct MPT3SAS_ADAPTER *ioc)
ioc_info(ioc, "removing unresponding devices: complete\n");
/* unblock devices */
- _scsih_ublock_io_all_device(ioc);
+ _scsih_ublock_io_all_device(ioc, 0);
}
static void
--
2.47.3
next prev parent reply other threads:[~2025-11-13 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 15:37 [PATCH v2 0/6] mpt3sas: Improve device readiness handling and event recovery Ranjan Kumar
2025-11-13 15:37 ` Ranjan Kumar [this message]
2025-11-13 15:37 ` [PATCH v2 2/6] mpt3sas: Added issue_scsi_cmd_to_bringup_drive module parameter part-1 Ranjan Kumar
2025-11-13 15:37 ` [PATCH v2 3/6] mpt3sas: improve device discovery and readiness handling for slow devices part-2 Ranjan Kumar
2025-11-13 15:37 ` [PATCH v2 4/6] mpt3sas: Add firmware event requeue support for busy devices Ranjan Kumar
2025-11-13 15:37 ` [PATCH v2 5/6] mpt3sas: Add configurable command retry limit for slow-to-respond devices Ranjan Kumar
2025-11-13 15:37 ` [PATCH v2 6/6] mpt3sas: Fixed the W=1 compilation warning Ranjan Kumar
2025-12-17 3:17 ` [PATCH v2 0/6] mpt3sas: Improve device readiness handling and event recovery Martin K. Petersen
2026-01-04 21:43 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113153712.31850-2-ranjan.kumar@broadcom.com \
--to=ranjan.kumar@broadcom.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=prayas.patel@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox