public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Herbolt <lukas@herbolt.com>
To: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, Lukas Herbolt <lukas@herbolt.com>
Subject: [PATCH 0/1] Fix unaligned queue_limit->io_opt on SAS and 4KN disk
Date: Fri, 14 Nov 2025 11:28:53 +0100	[thread overview]
Message-ID: <20251114102853.1476938-2-lukas@herbolt.com> (raw)

If there is an SAS attached disk we set the SCSI host opt_sectors in 
sas_host_setup() to either dma_opt_mapping_size() or host->max_sectors 
this value can be later assigned to the device queue_limit as io_opt, but 
there is no further check if the io_opt is aligned with the device limits.

Rounding down to device logical_sectors will keep the io_opt large enough 
to keep benefit of bigger IO but still aligned within the device limits. 

Lukas Herbolt (1):
  scsi: sd: Rounddown host->opt_sectors to logical sectors reported by
    the disk.

 drivers/scsi/sd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.51.1


             reply	other threads:[~2025-11-14 10:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 10:28 Lukas Herbolt [this message]
2025-11-14 10:28 ` [PATCH 1/1] scsi: sd: Rounddown host->opt_sectors to logical Lukas Herbolt
2025-11-20  3:26   ` Martin K. Petersen
2025-11-20 12:07     ` lukas
2025-11-20 16:07     ` John Garry
2025-11-21  8:34       ` lukas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114102853.1476938-2-lukas@herbolt.com \
    --to=lukas@herbolt.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox