Re: [PATCH v4] scsi: leapraid: Add new scsi driver

[kernel test robot <lkp@intel.com>]

Hi Hao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.18-rc6 next-20251117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hao-Dongdong/scsi-leapraid-Add-new-scsi-driver/20251116-192921
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/20251116112803.28078-1-doubled%40leap-io-kernel.com
patch subject: [PATCH v4] scsi: leapraid: Add new scsi driver
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20251118/202511182038.XDtPzsLQ-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251118/202511182038.XDtPzsLQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511182038.XDtPzsLQ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/leapraid/leapraid_func.c:4794:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    4794 |         default:
         |         ^
   drivers/scsi/leapraid/leapraid_func.c:4794:2: note: insert 'break;' to avoid fall-through
    4794 |         default:
         |         ^
         |         break; 
   1 warning generated.


vim +4794 drivers/scsi/leapraid/leapraid_func.c

  4741	
  4742	static void leapraid_fw_work(struct leapraid_adapter *adapter,
  4743				     struct leapraid_fw_evt_work *fw_evt)
  4744	{
  4745		struct leapraid_sas_dev *sas_dev;
  4746	
  4747		adapter->fw_evt_s.cur_evt = fw_evt;
  4748		leapraid_del_fw_evt_from_list(adapter, fw_evt);
  4749		if (adapter->access_ctrl.host_removing ||
  4750		    adapter->access_ctrl.pcie_recovering) {
  4751			leapraid_fw_evt_put(fw_evt);
  4752			adapter->fw_evt_s.cur_evt = NULL;
  4753			return;
  4754		}
  4755		switch (fw_evt->evt_type) {
  4756		case LEAPRAID_EVT_SAS_DISCOVERY:
  4757		{
  4758			struct leapraid_evt_data_sas_disc *evt_data;
  4759	
  4760			evt_data = fw_evt->evt_data;
  4761			if (evt_data->reason_code ==
  4762			    LEAPRAID_EVT_SAS_DISC_RC_STARTED &&
  4763			    !adapter->dev_topo.card.phys_num)
  4764				leapraid_sas_host_add(adapter, 0);
  4765			break;
  4766		}
  4767		case LEAPRAID_EVT_SAS_TOPO_CHANGE_LIST:
  4768			leapraid_sas_topo_chg_evt(adapter, fw_evt);
  4769			break;
  4770		case LEAPRAID_EVT_IR_CHANGE:
  4771			leapraid_sas_ir_chg_evt(adapter, fw_evt);
  4772			break;
  4773		case LEAPRAID_EVT_SAS_ENCL_DEV_STATUS_CHANGE:
  4774			leapraid_sas_enc_dev_stat_chg_evt(adapter, fw_evt);
  4775			break;
  4776		case LEAPRAID_EVT_REMOVE_DEAD_DEV:
  4777			while (scsi_host_in_recovery(adapter->shost) ||
  4778			       adapter->access_ctrl.shost_recovering) {
  4779				if (adapter->access_ctrl.host_removing ||
  4780				    adapter->fw_evt_s.fw_evt_cleanup)
  4781					goto out;
  4782	
  4783				ssleep(1);
  4784			}
  4785			leapraid_hardreset_async_logic(adapter);
  4786			break;
  4787		case LEAPRAID_EVT_TURN_ON_PFA_LED:
  4788			sas_dev = leapraid_get_sas_dev_by_hdl(adapter,
  4789							      fw_evt->dev_handle);
  4790			leapraid_set_led(adapter, sas_dev, true);
  4791			break;
  4792		case LEAPRAID_EVT_SCAN_DEV_DONE:
  4793			adapter->scan_dev_desc.scan_start = false;
> 4794		default:
  4795			break;
  4796		}
  4797	out:
  4798		leapraid_fw_evt_put(fw_evt);
  4799		adapter->fw_evt_s.cur_evt = NULL;
  4800	}
  4801	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki