From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Nilesh Javali <njavali@marvell.com>,
martin.petersen@oracle.com
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-scsi@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com, agurumurthy@marvell.com,
sdeodhar@marvell.com, emilne@redhat.com, jmeneghi@redhat.com
Subject: Re: [PATCH v2 07/12] qla2xxx: Delay module unload while fabric scan in progress
Date: Tue, 9 Dec 2025 11:14:05 +0300 [thread overview]
Message-ID: <202512090414.07Waorz0-lkp@intel.com> (raw)
In-Reply-To: <20251204151751.2321801-8-njavali@marvell.com>
Hi Nilesh,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Nilesh-Javali/qla2xxx-Add-Speed-in-SFP-print-information/20251204-233117
base: e6965188f84a7883e6a0d3448e86b0cf29b24dfc
patch link: https://lore.kernel.org/r/20251204151751.2321801-8-njavali%40marvell.com
patch subject: [PATCH v2 07/12] qla2xxx: Delay module unload while fabric scan in progress
config: x86_64-randconfig-r072-20251208 (https://download.01.org/0day-ci/archive/20251209/202512090414.07Waorz0-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202512090414.07Waorz0-lkp@intel.com/
New smatch warnings:
drivers/scsi/qla2xxx/qla_os.c:1187 qla2x00_wait_for_hba_ready() warn: if statement not indented
drivers/scsi/qla2xxx/qla_os.c:1189 qla2x00_wait_for_hba_ready() warn: inconsistent indenting
Old smatch warnings:
drivers/scsi/qla2xxx/qla_os.c:4249 qla2x00_mem_alloc() warn: missing unwind goto?
vim +1187 drivers/scsi/qla2xxx/qla_os.c
638a1a01d36a14 Sawan Chandak 2014-04-11 1176 static void
638a1a01d36a14 Sawan Chandak 2014-04-11 1177 qla2x00_wait_for_hba_ready(scsi_qla_host_t *vha)
86fbee86e94c7e Lalit Chandivade 2010-05-04 1178 {
86fbee86e94c7e Lalit Chandivade 2010-05-04 1179 struct qla_hw_data *ha = vha->hw;
783e0dc4f66ade Sawan Chandak 2016-07-06 1180 scsi_qla_host_t *base_vha = pci_get_drvdata(ha->pdev);
86fbee86e94c7e Lalit Chandivade 2010-05-04 1181
1d48390117c7df Dan Carpenter 2016-08-03 1182 while ((qla2x00_reset_active(vha) || ha->dpc_active ||
9d35894d338abc Sawan Chandak 2014-09-25 1183 ha->flags.mbox_busy) ||
9d35894d338abc Sawan Chandak 2014-09-25 1184 test_bit(FX00_RESET_RECOVERY, &vha->dpc_flags) ||
cedcf9d7bcbe3a Anil Gurumurthy 2025-12-04 1185 test_bit(FX00_TARGET_SCAN, &vha->dpc_flags) ||
cedcf9d7bcbe3a Anil Gurumurthy 2025-12-04 1186 (vha->scan.scan_flags & SF_SCANNING)) {
783e0dc4f66ade Sawan Chandak 2016-07-06 @1187 if (test_bit(UNLOADING, &base_vha->dpc_flags))
This if statement is indented too far.
783e0dc4f66ade Sawan Chandak 2016-07-06 1188 break;
86fbee86e94c7e Lalit Chandivade 2010-05-04 @1189 msleep(1000);
86fbee86e94c7e Lalit Chandivade 2010-05-04 1190 }
783e0dc4f66ade Sawan Chandak 2016-07-06 1191 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-12-09 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 15:17 [PATCH v2 00/12] qla2xxx: Misc feature and bug fixes Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 01/12] qla2xxx: Add Speed in SFP print information Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 02/12] qla2xxx: Add support for 64G SFP speed Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 03/12] qla2xxx: Add load flash firmware mailbox support for 28xxx Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 04/12] qla2xxx: Validate MCU signature before executing MBC 03h Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 05/12] qla2xxx: Add bsg interface to support firmware img validation Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 06/12] qla2xxx: Allow recovery for tape devices Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 07/12] qla2xxx: Delay module unload while fabric scan in progress Nilesh Javali
2025-12-09 8:14 ` Dan Carpenter [this message]
2025-12-04 15:17 ` [PATCH v2 08/12] qla2xxx: free sp in error path to fix system crash Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 09/12] qla2xxx: validate sp before freeing associated memory Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 10/12] qla2xxx: Query FW again before proceeding with login Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 11/12] qla2xxx: fix bsg_done causing double free Nilesh Javali
2025-12-04 15:17 ` [PATCH v2 12/12] qla2xxx: Update version to 10.02.10.100-k Nilesh Javali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512090414.07Waorz0-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=agurumurthy@marvell.com \
--cc=emilne@redhat.com \
--cc=jmeneghi@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sdeodhar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox