From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <dlemoal@kernel.org>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: [PATCH v4 4/5] scsi: sd: Move the sd_fops definition
Date: Tue, 16 Dec 2025 13:07:16 -0800 [thread overview]
Message-ID: <20251216210719.57256-5-bvanassche@acm.org> (raw)
In-Reply-To: <20251216210719.57256-1-bvanassche@acm.org>
Move the sd_fops definition such that the sd_unlock_native_capacity()
forward declaration can be removed.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/sd.c | 31 +++++++++++++++----------------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 58b33e9dad76..f52b435bf398 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -105,7 +105,6 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_ZBC);
static void sd_config_write_same(struct scsi_disk *sdkp,
struct queue_limits *lim);
static void sd_revalidate_disk(struct gendisk *);
-static void sd_unlock_native_capacity(struct gendisk *disk);
static DEFINE_IDA(sd_index_ida);
@@ -2174,21 +2173,6 @@ static void scsi_disk_free_disk(struct gendisk *disk)
put_device(&sdkp->disk_dev);
}
-static const struct block_device_operations sd_fops = {
- .owner = THIS_MODULE,
- .open = sd_open,
- .release = sd_release,
- .ioctl = sd_ioctl,
- .getgeo = sd_getgeo,
- .compat_ioctl = blkdev_compat_ptr_ioctl,
- .check_events = sd_check_events,
- .unlock_native_capacity = sd_unlock_native_capacity,
- .report_zones = sd_zbc_report_zones,
- .get_unique_id = sd_get_unique_id,
- .free_disk = scsi_disk_free_disk,
- .pr_ops = &sd_pr_ops,
-};
-
/**
* sd_eh_reset - reset error handling callback
* @scmd: sd-issued command that has failed
@@ -3882,6 +3866,21 @@ static void sd_unlock_native_capacity(struct gendisk *disk)
sdev->host->hostt->unlock_native_capacity(sdev);
}
+static const struct block_device_operations sd_fops = {
+ .owner = THIS_MODULE,
+ .open = sd_open,
+ .release = sd_release,
+ .ioctl = sd_ioctl,
+ .getgeo = sd_getgeo,
+ .compat_ioctl = blkdev_compat_ptr_ioctl,
+ .check_events = sd_check_events,
+ .unlock_native_capacity = sd_unlock_native_capacity,
+ .report_zones = sd_zbc_report_zones,
+ .get_unique_id = sd_get_unique_id,
+ .free_disk = scsi_disk_free_disk,
+ .pr_ops = &sd_pr_ops,
+};
+
/**
* sd_format_disk_name - format disk name
* @prefix: name prefix - ie. "sd" for SCSI disks
next prev parent reply other threads:[~2025-12-16 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 21:07 [PATCH v4 0/5] Clean up the SCSI disk driver source code Bart Van Assche
2025-12-16 21:07 ` [PATCH v4 1/5] scsi: sd: Move the sd_remove() function definition Bart Van Assche
2025-12-17 6:55 ` Johannes Thumshirn
2025-12-16 21:07 ` [PATCH v4 2/5] scsi: sd: Move the sd_config_discard() " Bart Van Assche
2025-12-17 6:56 ` Johannes Thumshirn
2025-12-16 21:07 ` [PATCH v4 3/5] scsi: sd: Move the scsi_disk_release() " Bart Van Assche
2025-12-17 6:57 ` Johannes Thumshirn
2025-12-16 21:07 ` Bart Van Assche [this message]
2025-12-17 6:58 ` [PATCH v4 4/5] scsi: sd: Move the sd_fops definition Johannes Thumshirn
2025-12-16 21:07 ` [PATCH v4 5/5] scsi: sd: Do not split error messages Bart Van Assche
2025-12-17 6:59 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216210719.57256-5-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=himanshu.madhani@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox