From: Greg KH <gregkh@linuxfoundation.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: core: Don't free dev_name() and hold refcount for parent manually
Date: Mon, 19 Jan 2026 16:54:18 +0100 [thread overview]
Message-ID: <2026011928-sliceable-shame-841d@gregkh> (raw)
In-Reply-To: <20260119142306.33676-1-tzungbi@kernel.org>
On Mon, Jan 19, 2026 at 10:23:06PM +0800, Tzung-Bi Shih wrote:
> static void scsi_host_cls_release(struct device *dev)
> {
> - put_device(&class_to_shost(dev)->shost_gendev);
> + /*
> + * Keep an empty release() to prevent device_release() from emitting a
> + * warning.
> + */
> }
Nope, sorry, something is VERY wrong if this is ever the case. The
driver core is warning you for a very good reason, don't attempt to work
around that at all, the message was placed there to help you, not for
you to ignore.
thanks,
greg k-h
prev parent reply other threads:[~2026-01-19 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 14:23 [PATCH v2] scsi: core: Don't free dev_name() and hold refcount for parent manually Tzung-Bi Shih
2026-01-19 15:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011928-sliceable-shame-841d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox