public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 4/4] vhost-scsi: Report direction completion support
Date: Sun, 22 Feb 2026 17:27:04 -0600	[thread overview]
Message-ID: <20260222232946.7637-5-michael.christie@oracle.com> (raw)
In-Reply-To: <20260222232946.7637-1-michael.christie@oracle.com>

This has vhost-scsi report that it supports direct completions.

When using a worker task per queue or group of queues with fast
backends then enabling direct completion and submissions increases
performance 20-30% with workloads like:

fio --filename=/dev/sdb  --direct=1 --rw=randrw --bs=8K \
    --ioengine=libaio --iodepth=128  --numjobs=$jobs

As jobs matches and passes the number of vCPUs in the VM then
the benefit increases.

However, when using a single worker then queueing completions
and submissions is best as the worker is busy handling mapping data
and setting/tearing down commands.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 drivers/vhost/scsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 1f00145116f4..653c08bb2520 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -2959,6 +2959,7 @@ static const struct target_core_fabric_ops vhost_scsi_ops = {
 	.tfc_tpg_attrib_attrs		= vhost_scsi_tpg_attrib_attrs,
 
 	.default_compl_type		= TARGET_QUEUE_COMPL,
+	.direct_compl_supp		= 1,
 	.default_submit_type		= TARGET_QUEUE_SUBMIT,
 	.direct_submit_supp		= 1,
 };
-- 
2.43.0


  parent reply	other threads:[~2026-02-22 23:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22 23:27 [PATCH 1/4] scsi: target: direct completion support Mike Christie
2026-02-22 23:27 ` [PATCH 1/4] scsi: target: Add support for completing commands from backend context Mike Christie
2026-03-11  2:06   ` Martin K. Petersen
2026-02-22 23:27 ` [PATCH 2/4] scsi: target: Use driver completion preference by default Mike Christie
2026-02-22 23:27 ` [PATCH 3/4] scsi: target: Allow userspace to set the completion type Mike Christie
2026-02-22 23:27 ` Mike Christie [this message]
2026-03-01  2:06 ` [PATCH 1/4] scsi: target: direct completion support Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260222232946.7637-5-michael.christie@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox