From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: kbusch@kernel.org, hch@lst.de, hare@suse.de,
chaitanyak@nvidia.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
James.Bottomley@HansenPartnership.com, mlombard@arkamax.eu,
jmeneghi@redhat.com, emilne@redhat.com, bgurney@redhat.com
Subject: Re: [PATCH V2 3/3] scsi: Convert async scanning to use the completion chain helper
Date: Tue, 24 Feb 2026 15:39:33 +0100 [thread overview]
Message-ID: <20260224143933.GC12308@lst.de> (raw)
In-Reply-To: <20260224122505.52401-4-mlombard@redhat.com>
On Tue, Feb 24, 2026 at 01:25:05PM +0100, Maurizio Lombardi wrote:
> diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
> index 7a193cc04e5b..d8a157bc9078 100644
> --- a/drivers/scsi/scsi_priv.h
> +++ b/drivers/scsi/scsi_priv.h
> @@ -132,7 +132,7 @@ extern void scsi_exit_procfs(void);
>
> /* scsi_scan.c */
> void scsi_enable_async_suspend(struct device *dev);
> -extern int scsi_complete_async_scans(void);
> +extern void scsi_complete_async_scans(void);
No need for the extern here.
> +DEFINE_COMPL_CHAIN(scanning_hosts);
This looks like it should be marked static.
prev parent reply other threads:[~2026-02-24 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 12:25 [PATCH V2 0/3] Ensure ordered namespace registration during async scan Maurizio Lombardi
2026-02-24 12:25 ` [PATCH V2 1/3] lib: Introduce completion chain helper Maurizio Lombardi
2026-02-24 14:35 ` Christoph Hellwig
2026-02-24 12:25 ` [PATCH V2 2/3] nvme-core: register namespaces in order during async scan Maurizio Lombardi
2026-02-24 14:37 ` Christoph Hellwig
2026-02-24 12:25 ` [PATCH V2 3/3] scsi: Convert async scanning to use the completion chain helper Maurizio Lombardi
2026-02-24 14:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224143933.GC12308@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bgurney@redhat.com \
--cc=bvanassche@acm.org \
--cc=chaitanyak@nvidia.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@arkamax.eu \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox