From: <ed.tsai@mediatek.com>
To: Peter Wang <peter.wang@mediatek.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Stanley Jhu <chu.stanley@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Ed Tsai <ed.tsai@mediatek.com>, <linux-scsi@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 2/2] ufs: host: mediatek: Add VCC on delay for stability
Date: Thu, 5 Mar 2026 16:29:15 +0800 [thread overview]
Message-ID: <20260305083610.2672344-3-ed.tsai@mediatek.com> (raw)
In-Reply-To: <20260305083610.2672344-1-ed.tsai@mediatek.com>
From: Ed Tsai <ed.tsai@mediatek.com>
Introduced a delay after enabling UFS5 VCC for MT6995 to ensure
voltage stability before refclk activation.
Signed-off-by: Ed Tsai <ed.tsai@mediatek.com>
---
drivers/ufs/host/ufs-mediatek.c | 11 +++++++++++
drivers/ufs/host/ufs-mediatek.h | 4 ++++
2 files changed, 15 insertions(+)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index b3daaa07e925..020302f8fbdf 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -1960,6 +1960,8 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)
static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
{
+ struct ufs_mtk_host *host = ufshcd_get_variant(hba);
+
ufshcd_fixup_dev_quirks(hba, ufs_mtk_dev_fixups);
if (ufs_mtk_is_broken_vcc(hba) && hba->vreg_info.vcc) {
@@ -1971,6 +1973,15 @@ static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
hba->dev_quirks &= ~UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM;
}
+ /*
+ * Add a delay after enable UFS5 VCC to ensure the voltage is
+ * stable before the refclk enable.
+ */
+ if (hba->dev_info.wspecversion >= 0x0500 &&
+ (host->ip_ver == IP_VER_MT6995_A0 ||
+ host->ip_ver == IP_VER_MT6995_B0))
+ hba->quirks |= UFSHCD_QUIRK_VCC_ON_DELAY;
+
ufs_mtk_vreg_fix_vcc(hba);
ufs_mtk_vreg_fix_vccqx(hba);
ufs_mtk_fix_ahit(hba);
diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h
index 9747277f11e8..8547a6f04990 100644
--- a/drivers/ufs/host/ufs-mediatek.h
+++ b/drivers/ufs/host/ufs-mediatek.h
@@ -220,6 +220,10 @@ enum {
IP_VER_MT6991_B0 = 0x10470000,
IP_VER_MT6993 = 0x10480000,
+ /* UFSHCI 5.0 */
+ IP_VER_MT6995_A0 = 0x10490000,
+ IP_VER_MT6995_B0 = 0x10500000,
+
IP_VER_NONE = 0xFFFFFFFF
};
--
2.45.2
next prev parent reply other threads:[~2026-03-05 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260305083610.2672344-1-ed.tsai@mediatek.com>
2026-03-05 8:29 ` [PATCH 1/2] ufs: core: Add quriks for VCC ramp-up delay ed.tsai
2026-03-05 12:24 ` Bart Van Assche
2026-03-06 0:19 ` Ed Tsai (蔡宗軒)
2026-03-06 2:15 ` Bart Van Assche
2026-03-06 2:16 ` Bart Van Assche
2026-03-05 8:29 ` ed.tsai [this message]
2026-03-05 12:20 ` [PATCH 2/2] ufs: host: mediatek: Add VCC on delay for stability Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305083610.2672344-3-ed.tsai@mediatek.com \
--to=ed.tsai@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=chu.stanley@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox