From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH 00/36] Enable lock context analysis for most SCSI drivers
Date: Thu, 12 Mar 2026 14:15:11 -0700 [thread overview]
Message-ID: <20260312211636.3245119-1-bvanassche@acm.org> (raw)
Hi Martin,
This patch series enables lock context analysis for most SCSI drivers. The
advantages are as follows:
- The compiler (only Clang) verifies whether the lock and unlock calls match
what has been declared via __must_hold(), __acquires() or __releases().
This is useful for catching locking bugs in error paths.
- Support for __guarded_by() is enabled. If a member variable is annotated
with __guarded_by(lock), the compiler will issue a warning if that member
variable is accessed without holding 'lock'.
More information about lock context analysis is available in the cover letter of
[PATCH v5 00/36] Compiler-Based Context- and Locking-Analysis
(https://lore.kernel.org/lkml/20251219154418.3592607-1-elver@google.com/).
Please consider this patch series for the next merge window.
Thanks,
Bart.
Bart Van Assche (36):
scsi: core: Prepare for enabling lock context analysis
scsi: scsi_debug: Prepare for enabling lock context analysis
scsi: sg: Prepare for enabling lock context analysis
scsi: st: Prepare for enabling lock context analysis
scsi: BusLogic: Introduce a local variable
scsi: BusLogic: Prepare for enabling lock context analysis
scsi: NCR5380: Prepare for enabling lock context analysis
scsi: aacraid: Prepare for enabling lock context analysis
scsi: aha152x: Prepare for enabling lock context analysis
scsi: aic7xxx: Prepare for enabling lock context analysis
scsi: be2iscsi: Prepare for enabling lock context analysis
scsi: bnx2fc: Prepare for enabling lock context analysis
scsi: bnx2i: Introduce a local variable
scsi: bnx2i: Prepare for enabling lock context analysis
scsi: csiostor: Prepare for enabling lock context analysis
scsi: fnic: Prepare for enabling lock context analysis
scsi: hpsa: Prepare for enabling lock context analysis
scsi: ibmvscsi_tgt: Prepare for enabling lock context analysis
scsi: ipr: Prepare for enabling lock context analysis
scsi: ips: Prepare for enabling lock context analysis
scsi: libfc: Prepare for enabling lock context analysis
scsi: libiscsi: Prepare for enabling lock context analysis
scsi: libsas: Prepare for enabling lock context analysis
scsi: lpfc: Prepare for enabling lock context analysis
scsi: megaraid_sas: Prepare for enabling lock context analysis
scsi: mvsas: Prepare for enabling lock context analysis
scsi: pm8001: Prepare for enabling lock context analysis
scsi: qedi: Prepare for enabling lock context analysis
scsi: qla1280: Prepare for enabling lock context analysis
scsi: qla2xxx: Prepare for enabling lock context analysis
scsi: qla4xxx: Prepare for enabling lock context analysis
scsi: ufs: Prepare for enabling lock context analysis
scsi: iSCSI transport: Prepare for enabling lock context analysis
scsi: smartpqi: Prepare for enabling lock context analysis
scsi: Enable lock context analysis
scsi: core: Protect host state changes with the host lock
drivers/scsi/BusLogic.c | 11 +++--
drivers/scsi/Makefile | 1 +
drivers/scsi/NCR5380.c | 4 +-
drivers/scsi/aacraid/Makefile | 2 +
drivers/scsi/aacraid/commctrl.c | 1 +
drivers/scsi/aacraid/commsup.c | 3 ++
drivers/scsi/aha152x.c | 1 +
drivers/scsi/aic7xxx/Makefile | 2 +
drivers/scsi/aic7xxx/aic79xx_osm.h | 2 +
drivers/scsi/aic7xxx/aic7xxx_osm.h | 2 +
drivers/scsi/aic7xxx/aicasm/Makefile | 3 ++
drivers/scsi/aic94xx/Makefile | 2 +
drivers/scsi/arcmsr/Makefile | 2 +
drivers/scsi/arm/Makefile | 2 +
drivers/scsi/be2iscsi/Makefile | 2 +
drivers/scsi/be2iscsi/be_main.c | 4 ++
drivers/scsi/bfa/Makefile | 3 ++
drivers/scsi/bnx2fc/Makefile | 3 ++
drivers/scsi/bnx2fc/bnx2fc.h | 5 +-
drivers/scsi/bnx2fc/bnx2fc_els.c | 2 +
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ++
drivers/scsi/bnx2fc/bnx2fc_io.c | 6 ++-
drivers/scsi/bnx2i/Makefile | 3 ++
drivers/scsi/bnx2i/bnx2i_hwi.c | 14 ++++--
drivers/scsi/bnx2i/bnx2i_iscsi.c | 1 +
drivers/scsi/csiostor/Makefile | 2 +
drivers/scsi/csiostor/csio_hw.c | 12 +++++
drivers/scsi/csiostor/csio_lnode.c | 3 ++
drivers/scsi/csiostor/csio_rnode.c | 6 +++
drivers/scsi/csiostor/csio_scsi.c | 6 +++
drivers/scsi/cxgbi/Makefile | 3 ++
drivers/scsi/device_handler/Makefile | 3 ++
drivers/scsi/elx/Makefile | 1 +
drivers/scsi/esas2r/Makefile | 3 ++
drivers/scsi/fcoe/Makefile | 3 ++
drivers/scsi/fnic/Makefile | 3 ++
drivers/scsi/fnic/fdls_disc.c | 52 ++++++++++++++++++++-
drivers/scsi/fnic/fip.c | 2 +
drivers/scsi/fnic/fnic_fcs.c | 6 +++
drivers/scsi/fnic/fnic_scsi.c | 4 ++
drivers/scsi/hisi_sas/Makefile | 3 ++
drivers/scsi/hosts.c | 13 ++++--
drivers/scsi/hpsa.c | 2 +-
drivers/scsi/ibmvscsi/Makefile | 3 ++
drivers/scsi/ibmvscsi_tgt/Makefile | 3 ++
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 7 +++
drivers/scsi/ipr.c | 11 +++++
drivers/scsi/ips.c | 1 +
drivers/scsi/isci/Makefile | 3 ++
drivers/scsi/libfc/Makefile | 2 +
drivers/scsi/libfc/fc_disc.c | 6 ++-
drivers/scsi/libfc/fc_exch.c | 6 +++
drivers/scsi/libfc/fc_fcp.c | 4 ++
drivers/scsi/libiscsi.c | 19 +++++++-
drivers/scsi/libsas/Makefile | 2 +
drivers/scsi/libsas/sas_ata.c | 2 +-
drivers/scsi/lpfc/lpfc_els.c | 2 +
drivers/scsi/lpfc/lpfc_nportdisc.c | 1 +
drivers/scsi/lpfc/lpfc_scsi.c | 1 +
drivers/scsi/lpfc/lpfc_sli.c | 2 +
drivers/scsi/megaraid/Makefile | 3 ++
drivers/scsi/megaraid/megaraid_sas.h | 9 ++--
drivers/scsi/megaraid/megaraid_sas_base.c | 17 +++++--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +
drivers/scsi/mpt3sas/Makefile | 3 ++
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +-
drivers/scsi/mvsas/Makefile | 2 +
drivers/scsi/mvsas/mv_sas.c | 7 +++
drivers/scsi/pcmcia/Makefile | 2 +
drivers/scsi/pm8001/Makefile | 1 +
drivers/scsi/pm8001/pm80xx_hwi.c | 2 +
drivers/scsi/qedf/Makefile | 3 ++
drivers/scsi/qedi/Makefile | 3 ++
drivers/scsi/qedi/qedi_fw.c | 1 +
drivers/scsi/qla1280.c | 18 +++++++
drivers/scsi/qla2xxx/Makefile | 3 ++
drivers/scsi/qla2xxx/qla_nx.c | 2 +
drivers/scsi/qla2xxx/qla_target.c | 29 +++++++-----
drivers/scsi/qla2xxx/qla_tmpl.c | 1 +
drivers/scsi/qla4xxx/Makefile | 3 ++
drivers/scsi/qla4xxx/ql4_nx.c | 2 +
drivers/scsi/qla4xxx/ql4_os.c | 6 +--
drivers/scsi/scsi_debug.c | 16 +++++++
drivers/scsi/scsi_lib.c | 3 +-
drivers/scsi/scsi_scan.c | 12 +++++
drivers/scsi/scsi_sysfs.c | 7 +--
drivers/scsi/scsi_transport_iscsi.c | 1 +
drivers/scsi/sg.c | 1 +
drivers/scsi/smartpqi/Makefile | 3 ++
drivers/scsi/smartpqi/smartpqi_init.c | 18 +++++++
drivers/scsi/snic/Makefile | 3 ++
drivers/scsi/st.c | 1 +
drivers/scsi/sym53c8xx_2/Makefile | 2 +
drivers/ufs/Makefile | 2 +
drivers/ufs/core/Makefile | 2 +
drivers/ufs/core/ufs-debugfs.c | 8 +++-
drivers/ufs/core/ufshcd.c | 10 ++++
drivers/ufs/host/Makefile | 2 +
include/scsi/libiscsi.h | 5 +-
include/scsi/scsi_host.h | 25 +++++++---
100 files changed, 466 insertions(+), 62 deletions(-)
next reply other threads:[~2026-03-12 21:17 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 21:15 Bart Van Assche [this message]
2026-03-12 21:15 ` [PATCH 01/36] scsi: core: Prepare for enabling lock context analysis Bart Van Assche
2026-03-12 21:15 ` [PATCH 02/36] scsi: scsi_debug: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 03/36] scsi: sg: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 04/36] scsi: st: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 05/36] scsi: BusLogic: Introduce a local variable Bart Van Assche
2026-03-26 20:50 ` Khalid Aziz
2026-03-12 21:15 ` [PATCH 06/36] scsi: BusLogic: Prepare for enabling lock context analysis Bart Van Assche
2026-03-26 20:59 ` Khalid Aziz
2026-03-12 21:15 ` [PATCH 07/36] scsi: NCR5380: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 08/36] scsi: aacraid: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 09/36] scsi: aha152x: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 10/36] scsi: aic7xxx: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 11/36] scsi: be2iscsi: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 12/36] scsi: bnx2fc: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 13/36] scsi: bnx2i: Introduce a local variable Bart Van Assche
2026-03-12 21:15 ` [PATCH 14/36] scsi: bnx2i: Prepare for enabling lock context analysis Bart Van Assche
2026-03-12 21:15 ` [PATCH 15/36] scsi: csiostor: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 16/36] scsi: fnic: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 17/36] scsi: hpsa: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 18/36] scsi: ibmvscsi_tgt: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 19/36] scsi: ipr: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 20/36] scsi: ips: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 21/36] scsi: libfc: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 22/36] scsi: libiscsi: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 23/36] scsi: libsas: " Bart Van Assche
2026-03-13 1:35 ` Jason Yan
2026-03-12 21:15 ` [PATCH 24/36] scsi: lpfc: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 25/36] scsi: megaraid_sas: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 26/36] scsi: mvsas: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 27/36] scsi: pm8001: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 28/36] scsi: qedi: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 29/36] scsi: qla1280: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 30/36] scsi: qla2xxx: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 31/36] scsi: qla4xxx: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 32/36] scsi: ufs: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 33/36] scsi: iSCSI transport: " Bart Van Assche
2026-03-12 21:15 ` [PATCH 34/36] scsi: smartpqi: " Bart Van Assche
2026-03-16 15:36 ` Don.Brace
2026-03-12 21:15 ` [PATCH 35/36] scsi: Enable " Bart Van Assche
2026-03-12 21:15 ` [PATCH 36/36] scsi: core: Protect host state changes with the host lock Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312211636.3245119-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox