Re: [PATCH v3 2/6] scsi: Protect INQUIRY sysfs attributes with mutex

[Brian Bunker <brian@purestorage.com>]

On 5/5/26 1:24 AM, Bart Van Assche wrote:
>> This changes the sysfs ABI for /sys/.../vendor, /sys/.../model and
>> /sys/.../rev.
>
> Not necessarily. If the format specifiers %-8s / %-16s / %-4s are used
> for reporting these member variables via sysfs, the sysfs output should
> remain the same.

Agreed - left-justified width specifiers would re-pad on the way out
and keep the byte-for-byte sysfs output. The current diff uses plain
%s for the sysfs attributes:

  -sdev_rd_attr (vendor, "%.8s\n");
  -sdev_rd_attr (model,  "%.16s\n");
  -sdev_rd_attr (rev,    "%.4s\n");
  +sdev_rd_attr (vendor, "%s\n");
  +sdev_rd_attr (model,  "%s\n");
  +sdev_rd_attr (rev,    "%s\n");

so as posted "PURE    \n" still shrinks to "PURE\n". If those become
%-8s / %-16s / %-4s in the next revision the ABI concern goes away.

Thanks,
Brian