From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Brian Bunker <brian@purestorage.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: [PATCH v2 2/3] scsi: core: Use the INQUIRY-related constants
Date: Fri, 15 May 2026 13:52:20 -0700 [thread overview]
Message-ID: <20260515205222.1754621-3-bvanassche@acm.org> (raw)
In-Reply-To: <20260515205222.1754621-1-bvanassche@acm.org>
Use symbolic names instead of numeric constants to access the vendor and
model information.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/scsi_scan.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index a35a5f777d16..b0473f4595c1 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -728,9 +728,13 @@ static int scsi_probe_lun(struct scsi_device *sdev, unsigned char *inq_result,
}
if (result == 0) {
- scsi_sanitize_inquiry_string(&inq_result[8], 8);
- scsi_sanitize_inquiry_string(&inq_result[16], 16);
- scsi_sanitize_inquiry_string(&inq_result[32], 4);
+ scsi_sanitize_inquiry_string(&inq_result[INQUIRY_VENDOR_OFFSET],
+ INQUIRY_VENDOR_LEN);
+ scsi_sanitize_inquiry_string(&inq_result[INQUIRY_MODEL_OFFSET],
+ INQUIRY_MODEL_LEN);
+ scsi_sanitize_inquiry_string(
+ &inq_result[INQUIRY_REVISION_OFFSET],
+ INQUIRY_REVISION_LEN);
response_len = inq_result[4] + 5;
if (response_len > 255)
@@ -743,8 +747,9 @@ static int scsi_probe_lun(struct scsi_device *sdev, unsigned char *inq_result,
* corresponding bit fields in scsi_device, so bflags
* need not be passed as an argument.
*/
- *bflags = scsi_get_device_flags(sdev, &inq_result[8],
- &inq_result[16]);
+ *bflags = scsi_get_device_flags(sdev,
+ &inq_result[INQUIRY_VENDOR_OFFSET],
+ &inq_result[INQUIRY_MODEL_OFFSET]);
/* When the first pass succeeds we gain information about
* what larger transfer lengths might work. */
next prev parent reply other threads:[~2026-05-15 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 20:52 [PATCH v2 0/3] Rework the struct scsi_device inquiry information Bart Van Assche
2026-05-15 20:52 ` [PATCH v2 1/3] scsi: core, target: Add INQUIRY-related constants into <scsi/scsi_common.h> Bart Van Assche
2026-05-15 20:52 ` Bart Van Assche [this message]
2026-05-15 20:52 ` [PATCH v2 3/3] scsi: core: Convert INQUIRY information Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515205222.1754621-3-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brian@purestorage.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox