From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0748F2DA76C for ; Thu, 11 Jun 2026 12:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781182677; cv=none; b=tnyXlAQZCHqyHw0ZdSJRMr9U16NhHWykxxkb/EuWz14c4EweWeWUqa+FIdWghd5fJ8vjrqcyTNaOiCIDSALdcUrUSvFtJOnlexq/hxqPnlbjds7gJPVQOv2yx02oz/WFoX+E1gTjVc7QARSI0AOzHAc1ulwBJlchizjGjLKCrs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781182677; c=relaxed/simple; bh=pMz0XopnIHTyXSKV4o5NA6+8Cj6CQUbxxVzNeeDGF4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OHx//jZKVXI2s3dYqyEubSfg1huML3Zc/cUsC1mWDVOnPfM4NYuWJZpV6iwMoWJViMOZyUoGzDriHdAeej9MSX94AA5PiS6LFk8B4tu6voA5zCXePvXaDdUrzZ6cN/cAy4xNIGjzbuL4dJDb/nMwngdsN11L9DJaHfViTccDfVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K57/wpwx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K57/wpwx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781182675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wutI1NEOrxe0Ga9sQ5pG620uXi0d0C5Aj7NTI3FNepo=; b=K57/wpwxaGIdnvZmSZ72MRcFMPsmqT+oLnncu0FEpDuzsHMOZ6zfd8bQHzKMiJTk84MDJV w1rdZ3KMkc33EqYv+NxlpFeB7+n5bD7mdlrEpq19bmmYH6WRWBSsDTHvSXsfyvw61Kgbbi eozNtVkDMS6T4umKuIQj18W+73fArMc= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-_h9LaK_xPp-Cw2A3pjQP9w-1; Thu, 11 Jun 2026 08:57:51 -0400 X-MC-Unique: _h9LaK_xPp-Cw2A3pjQP9w-1 X-Mimecast-MFC-AGG-ID: _h9LaK_xPp-Cw2A3pjQP9w_1781182668 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1984519775EB; Thu, 11 Jun 2026 12:57:48 +0000 (UTC) Received: from localhost (unknown [10.2.16.137]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 179B1180057F; Thu, 11 Jun 2026 12:57:43 +0000 (UTC) Date: Wed, 10 Jun 2026 11:37:47 -0400 From: Stefan Hajnoczi To: Sumit Saxena , "Michael S. Tsirkin" Cc: "Martin K . Petersen" , Jens Axboe , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Adam Radford , Khalid Aziz , Adaptec OEM Raid Solutions , Matthew Wilcox , Hannes Reinecke , "Juergen E . Fischer" , Russell King , linux-arm-kernel@lists.infradead.org, Finn Thain , Michael Schmitz , Anil Gurumurthy , Sudarsana Kalluru , Oliver Neukum , Ali Akcaagac , Jamie Lenehan , Ram Vegesna , target-devel@vger.kernel.org, Bradley Grove , Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , Yihang Li , Don Brace , storagedev@microchip.com, HighPoint Linux Team , Tyrel Datwyler , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Brian King , Lee Duncan , Chris Leech , Mike Christie , open-iscsi@googlegroups.com, Justin Tee , Paul Ely , Kashyap Desai , Shivasharan S , Chandrakanth Patil , megaraidlinux.pdl@broadcom.com, Sathya Prakash Veerichetty , Sreekanth Reddy , mpi3mr-linuxdrv.pdl@broadcom.com, Suganath Prabu Subramani , Ranjan Kumar , MPT-FusionLinux.pdl@broadcom.com, Daniel Palmer , GOTO Masanori , Jack Wang , Geoff Levand , Michael Reed , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Narsimhulu Musini , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , linux-hyperv@vger.kernel.org, "Michael S . Tsirkin" , Jason Wang , Paolo Bonzini , Eugenio Perez , virtualization@lists.linux.dev, Vishal Bhakta , bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, John Garry Subject: Re: [PATCH v3 2/4] scsi: host: allocate struct Scsi_Host on the NUMA node of the host adapter Message-ID: <20260610153747.GA121666@fedora> References: <20260609121806.2121755-1-sumit.saxena@broadcom.com> <20260609121806.2121755-3-sumit.saxena@broadcom.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="57Se20/pMUpk+P8R" Content-Disposition: inline In-Reply-To: <20260609121806.2121755-3-sumit.saxena@broadcom.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 --57Se20/pMUpk+P8R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 09, 2026 at 05:48:01PM +0530, Sumit Saxena wrote: > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index 5fdaa71f0652..88375574cb18 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -929,7 +929,7 @@ static int virtscsi_probe(struct virtio_device *vdev) > num_targets =3D virtscsi_config_get(vdev, max_target) + 1; > =20 > shost =3D scsi_host_alloc(&virtscsi_host_template, > - struct_size(vscsi, req_vqs, num_queues)); > + struct_size(vscsi, req_vqs, num_queues), NULL); A virtio_device has a parent (this is the virtio transport, like virtio_pci) and that may have NUMA node. drivers/virtio/virtio.c:register_virtio_device() could call set_dev_node(dev, dev_to_node(dev->parent)) to propagate the NUMA node to the virtio_device if it is not already automatically propagated. Stefan --57Se20/pMUpk+P8R Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmophMsACgkQnKSrs4Gr c8h+7Af/Yl5xc4DOlpzwRNKEPqqogmtmADQbRI91eNljCoArG1qdxcTTSKksIgWC 5g0jjNOCwbOatljS+FxPkDgpPYoZbsIv+K4p/D6UyHLP+Dff2FQhwPaAKkOvJi6k 9BoNOORgp8ZKrf0RrCTr2M5clKgG0GT+5WxgezSZtTh6wSoN0ksL5kwqx+8B4sWw irnTFz4hZhKlUsYHWWYvNhiq0ChdmzYMdxw6GFwIWrRpNcElfSmOAMBE12bJeqIi u2/3ah3cSSanhmuITCC+dXImHUlYtxtFRBowqsxCEtdiRFs5srPStR/WW8yyZoXe mhXbMPjGmQXNdAT61yT9lw+ZVx2y1w== =kfg0 -----END PGP SIGNATURE----- --57Se20/pMUpk+P8R--