From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4297403AF8; Tue, 30 Jun 2026 10:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782816869; cv=none; b=Fh/RL2OKi6UjrXKL7GBuQjNsx/64pGf5UwTOlXsOxjYGsDX8t16DInkFZczCq8NCEi4LNp0O1lZirD+lg7orAc+nTNtfSXM4yDe6mmmZJtvyUSsGtrhlnsI+bnz514S5ZHO2vAjFxtzcBc2vtSBa6hV5m/nJtQQ1cj62HOTBRRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782816869; c=relaxed/simple; bh=lZl3pHReeTA4PBsfdv9T3/Murxcq0XUtd1bdKzlK6cA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jrQxv/sH+O/wgz3b8kQD+c/+2LYk/A/G+mYAUgKh1vBsty+6RrVU4wJjiDa+aPupnouDJhZD2Sj9WK+2bk59RM6N8GFExVtCEBb1IBYbJNqj8Fvx0iHnzcUtUueEN8ilwzKwgjbdm5KKGc/1HAUTvPWs8wbhresddqi1Wuq6YRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RJE2rCy7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RJE2rCy7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63BB21F000E9; Tue, 30 Jun 2026 10:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782816868; bh=305VH6OUix40v7/Cr6ljvxi18Oyq/nvdnChwFnVwVXk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=RJE2rCy7Arqo6bbDH+p8izGeNvi9sDYWDv3cAyD5NIV2YpMNtN63lEN+vEGc2Nw87 yi59zz6dEg25JB7hHQsk3lzyiblRdvvgKrwW/b6iekZzAN7iQ96q459V59kHvDgUhy 9J+YJ1bPTvRzZvdMlNscfSc+kP8CM1037BvOuhifT7phPEJtVJ4xRCOtjMT0Sq/ydP 22nv23K4tfPr4FUFhV14ETFspsKhAvt3gIPHn4s95pA9VIwJBacdP2l90xcmdJ3je4 1EtrHZo9bUd3kV9VHGWHSIqF8aznRprqA1Gnl6b+oqiD1hXHcEHI8FNV2Zxi/qL8ba d843Q/TXn1+3Q== From: "Mike Rapoport (Microsoft)" Date: Tue, 30 Jun 2026 13:54:19 +0300 Subject: [PATCH 2/4] scsi: proc: use kmalloc() in proc writers Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260630-b4-scsi-v1-2-494fb37ebe7b@kernel.org> References: <20260630-b4-scsi-v1-0-494fb37ebe7b@kernel.org> In-Reply-To: <20260630-b4-scsi-v1-0-494fb37ebe7b@kernel.org> To: "Martin K. Petersen" Cc: Brian King , "James E.J. Bottomley" , Matthew Wilcox , Mike Rapoport , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org X-Mailer: b4 0.15.2 proc_scsi_host_write(), proc_scsi_write() and proc_scsi_devinfo_write() allocate temporary buffers for /proc writes using __get_free_page(). These buffers can be allocated with kmalloc() as there's nothing special about them to go directly to the page allocator. kmalloc() provides a better API that does not require ugly casts and kfree() does not need to know the size of the freed object. Replace use of __get_free_page() with kmalloc(). Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com Signed-off-by: Mike Rapoport (Microsoft) --- drivers/scsi/scsi_devinfo.c | 4 ++-- drivers/scsi/scsi_proc.c | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index 15ffbe93ac72..6dd342fe9a69 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/drivers/scsi/scsi_devinfo.c @@ -691,7 +691,7 @@ static ssize_t proc_scsi_devinfo_write(struct file *file, if (!buf || length>PAGE_SIZE) return -EINVAL; - if (!(buffer = (char *) __get_free_page(GFP_KERNEL))) + if (!(buffer = kmalloc(PAGE_SIZE, GFP_KERNEL))) return -ENOMEM; if (copy_from_user(buffer, buf, length)) { err =-EFAULT; @@ -708,7 +708,7 @@ static ssize_t proc_scsi_devinfo_write(struct file *file, scsi_dev_info_list_add_str(buffer); out: - free_page((unsigned long)buffer); + kfree(buffer); return err; } diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c index 1799dcae775c..fdc355d783da 100644 --- a/drivers/scsi/scsi_proc.c +++ b/drivers/scsi/scsi_proc.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include @@ -74,7 +75,7 @@ static ssize_t proc_scsi_host_write(struct file *file, const char __user *buf, if (!shost->hostt->write_info) return -EINVAL; - page = (char *)__get_free_page(GFP_KERNEL); + page = kmalloc(PAGE_SIZE, GFP_KERNEL); if (page) { ret = -EFAULT; if (copy_from_user(page, buf, count)) @@ -82,7 +83,7 @@ static ssize_t proc_scsi_host_write(struct file *file, const char __user *buf, ret = shost->hostt->write_info(shost, page, count); } out: - free_page((unsigned long)page); + kfree(page); return ret; } @@ -412,7 +413,7 @@ static ssize_t proc_scsi_write(struct file *file, const char __user *buf, if (!buf || length > PAGE_SIZE) return -EINVAL; - buffer = (char *)__get_free_page(GFP_KERNEL); + buffer = kmalloc(PAGE_SIZE, GFP_KERNEL); if (!buffer) return -ENOMEM; @@ -467,7 +468,7 @@ static ssize_t proc_scsi_write(struct file *file, const char __user *buf, err = length; out: - free_page((unsigned long)buffer); + kfree(buffer); return err; } -- 2.53.0