From: Damien Le Moal <dlemoal@kernel.org>
To: linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Igor Pylypiv <ipylypiv@google.com>,
John Garry <john.g.garry@oracle.com>,
Jason Yan <yanaijie@huawei.com>
Subject: [PATCH v3 0/2] fixup handling of timeouts with deferred QCs
Date: Mon, 13 Jul 2026 13:12:50 +0900 [thread overview]
Message-ID: <20260713041252.463401-1-dlemoal@kernel.org> (raw)
This patch series fixes libata and libsas to correctly handles deferred
queued commands in case of a timeout error, to avoid excessive delays in
waking up the scsi EH task.
Igor,
My apologies for the churn, but please retest !
Also, I added your Signed-off-by on patch 2 since half of it is yours.
Martin,
Once reviewed, I or you can take both patches ?
Changes from v2:
- Modified patch 1 to avoid the problem reported by Sashiko that requeued
deferred QCs may be re-ssued immediately by the block layer, thus
potentially keeping the device busy. The modification now relies on
libata-EH to perform the requeue instead of immediately doing it from
the eh_timed_out operation.
- Modified patch 2 to use the new helper function defined in patch 1.
Changes from v1:
- Modified patch 1 to ignore timed out deferred QCs in
ata_scsi_requeue_deferred_qc() to let ata_scsi_cmd_error_handler()
correctly handle this case.
Damien Le Moal (2):
ata: libata-scsi: terminate deferred commands on time out
scsi: libsas: terminate deferred commands on time out
drivers/ata/libata-eh.c | 36 ++++++++++++++++++++++++++++-
drivers/ata/libata-scsi.c | 22 ++++++++++++++++++
drivers/scsi/libsas/sas_scsi_host.c | 17 ++++++++++++++
include/linux/libata.h | 4 ++++
include/scsi/libsas.h | 2 ++
5 files changed, 80 insertions(+), 1 deletion(-)
--
2.55.0
next reply other threads:[~2026-07-13 4:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 4:12 Damien Le Moal [this message]
2026-07-13 4:12 ` [PATCH v3 1/2] ata: libata-scsi: terminate deferred commands on time out Damien Le Moal
2026-07-13 10:51 ` Niklas Cassel
2026-07-14 5:41 ` Damien Le Moal
2026-07-13 18:07 ` Igor Pylypiv
2026-07-13 23:41 ` Damien Le Moal
2026-07-13 4:12 ` [PATCH v3 2/2] scsi: libsas: " Damien Le Moal
2026-07-13 4:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713041252.463401-1-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=ipylypiv@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox