From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AB5E3769EF for ; Tue, 14 Jul 2026 11:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784027190; cv=none; b=LWuwwEFA1GHf1afOJF6gndUZpQ7vDafwwn7lxf+m112LXGCvI3Ef6r7bDAhc+3vVTuIgYgihHjSOg6jXF3gbm4mEthgGqbgb0qRPzRcgHoIlCfFWwWzhNrbDnUJELsEkQnnxeQwTSUBU7eFqPVBe2d3kIH0zu5AApNN5ZNuM0Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784027190; c=relaxed/simple; bh=gn56do6UymBfQWbwUaGVs9ZuaYzCgOfCgsId/kEnOTo=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Ha00i4LmaNuVE1cg13zp2BacnqMpEpvi5e16GRrYxc6njiqodqX+7cDXsjtuRRt4L7yLP229fZhGhRWB9ds+1fZuCSpm2Z0yaHT0bnKbQbRq4uBHPKu0seORgcPV/097ewIRzskF5zolnIcbZf0L9yS8stF7xzlu9iSZU7OCtjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KJNN54TK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KJNN54TK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0D101F00A3D; Tue, 14 Jul 2026 11:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784027189; bh=KLrkJxYydpTBDXfIEBOUbJn+4/iRar0Tmc2GClJBY9Y=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KJNN54TKY6wn/JRM5ZPTOi51uISqyoaXdbNuMBrzWmLqeFh3ttPn7aiNi6uNvzibG g3LW6BMzwjQN9XQaRZzLiJu5z6c05kSoatQCSecaz8iqh3kyaWMx8OJgp0ikaZxzLR ghJHVYwyz45/mtgh99wuCMiw29tGJJApsRE8VUtPmM1Nza/nCQ6Q5f0KMUWH7na8Y/ 86IIMntxyWa16QnuQMvUDbjGbeIkMhdCm0c3Yj8T/bn5+1B1DJeQU9Z2Y3AuTMrNNi sdIi9n5lIrPxAx1TbAPDO+SvNdrx5RUwrNhDT86SBTF7S/WURMRAz22XWOtkygmriR EFEft13B5DxHg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 10/56] scsi: qla2xxx: Add extended status continuation and marker IOCBs Reply-To: sashiko-reviews@lists.linux.dev To: "Nilesh Javali" Cc: linux-scsi@vger.kernel.org In-Reply-To: <20260714095353.289460-11-njavali@marvell.com> References: <20260714095353.289460-1-njavali@marvell.com> <20260714095353.289460-11-njavali@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Jul 2026 11:06:28 +0000 Message-Id: <20260714110628.F0D101F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The commit message explicitly claims to add a structure named `m= rk_entry_ext_t`, but this structure is completely missing from the patch an= d the entire codebase. -- --- Patch [10]: [PATCH v4 10/56] scsi: qla2xxx: Add extended status continu= ation and marker IOCBs --- commit 7582f36ee7094ac8210ce81133caf62e1a0ea4c4 Author: Anil Gurumurthy scsi: qla2xxx: Add extended status continuation and marker IOCBs This commit adds the 128-byte extended status continuation structure for 29xx firmware and includes the qla_fw29.h header. The commit message also mentions adding a marker IOCB structure. > Add the 128-byte sts_cont_entry_ext_t and mrk_entry_ext_t > structures required by 29xx firmware. > diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_de= f.h > --- a/drivers/scsi/qla2xxx/qla_def.h > +++ b/drivers/scsi/qla2xxx/qla_def.h [ ... ] > @@ -2360,6 +2361,15 @@ typedef struct { > uint8_t reserved_2[48]; > } mrk_entry_t; > =20 > +/* 29xx definitions */ > +struct sts_cont_entry_ext { > + uint8_t entry_type; /* Entry type. */ > + uint8_t entry_count; /* Entry count. */ > + uint8_t sys_define; /* System defined. */ > + uint8_t entry_status; /* Entry Status. */ > + uint8_t data[124]; /* data */ > +}; > + [Severity: Medium] This isn't a bug, but the commit message states that the mrk_entry_ext_t structure is being added. Looking at the changes in qla_def.h above, only the sts_cont_entry_ext structure is included. Is the mrk_entry_ext_t structure missing from this patch, or should the commit message be updated to reflect that it is not included? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260714095353.2894= 60-1-njavali@marvell.com?part=3D10