Re: [PATCH v4 41/56] scsi: qla2xxx: Replace __le16 bitfields with scalar and accessors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The patch replaces `__le16` bitfields with scalar fields and accessor functions in several 29xx extended IOCB structures to fix implementation-defined bitfield packing on big-endian hosts. However, it completely misses `struct vp_rpt_id_entry_24xx_ext`, which exhibits the exact same buggy pattern (`__le16 vp_idx : 9; __le16 vp_status : 7;`).
--

--- Patch [41]: [PATCH v4 41/56] scsi: qla2xxx: Replace __le16 bitfields with scalar and accessors ---
commit 0cf9b60149a7b5c26196bf1b6738600fa9600e4f
Author: Nilesh Javali <njavali@marvell.com>

scsi: qla2xxx: Replace __le16 bitfields with scalar and accessors

Replace the three sets of __le16 bitfields in 29xx extended IOCB structures
with a single __le16 scalar field and provide inline accessor functions
that use proper le16_to_cpu()/cpu_to_le16() with shift-and-mask operations.
This fixes implementation-defined bitfield packing on big-endian hosts.

> diff --git a/drivers/scsi/qla2xxx/qla_fw29.h b/drivers/scsi/qla2xxx/qla_fw29.h
> index 600a40d8bd5ff..63bf350ddffc0 100644
> --- a/drivers/scsi/qla2xxx/qla_fw29.h
> +++ b/drivers/scsi/qla2xxx/qla_fw29.h
[ ... ]
> @@ -563,9 +586,7 @@ struct abts_entry_24xx_ext {
>  	__le16	nport_handle;		/* type 0x54 only */
>  
>  	__le16	control_flags;		/* type 0x55 only */
> -	__le16	vp_idx : 9;		/* VP index 9 bits */
> -	__le16	reserved_1_sof : 3;
> -	__le16	sof_type : 4;		/* sof_type is upper nibble */
> +	__le16	vp_idx_sof;		/* bits [8:0]=VP index, [15:12]=SOF type */
>  
>  	__le32	rx_xch_addr;

[Severity: High]
Does this patch miss updating struct vp_rpt_id_entry_24xx_ext which seems to
exhibit the exact same buggy pattern?

drivers/scsi/qla2xxx/qla_fw29.h:
struct vp_rpt_id_entry_24xx_ext {
    ...
	__le16	vp_idx : 9;		/* VP Index 9bits */
	__le16	vp_status : 7;		/* VP Status 7bits */
    ...
};

This structure is used in qla24xx_report_id_acquisition() in qla_mbx.c where
the improperly packed bitfields are accessed from the hardware DMA response:

drivers/scsi/qla2xxx/qla_mbx.c:qla24xx_report_id_acquisition() {
    ...
		vp_idx = rptid_entry_ext->vp_idx;
		vp_status = rptid_entry_ext->vp_status;
    ...
}

This could result in corrupted virtual port data on big-endian hosts.
Is this intentional or should it be converted to a scalar with accessors as
well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714095353.289460-1-njavali@marvell.com?part=41