From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] scsi: ufs: dt-bindings: Add missing mcq reg for qcom,sa8255p-ufshc
Date: Mon, 20 Jul 2026 02:44:43 +0000 [thread overview]
Message-ID: <20260720024444.5F80D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260720023552.2667237-1-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Device Tree schema update fails to enforce the presence of the newly documented `mcq` register space and `reg-names` property.
--
--- Patch [1]: [PATCH v2] scsi: ufs: dt-bindings: Add missing mcq reg for qcom,sa8255p-ufshc ---
commit 871a91874eb00f9814a93dfb44bc94d0b96e8791
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
scsi: ufs: dt-bindings: Add missing mcq reg for qcom,sa8255p-ufshc
Qualcomm UFS controller found on SoCs SA8255P/SA8797P has a MCQ I/O
address space. It should be defined in the bindings even though Linux
driver currently doesn't utilize it. Fix the binding before it gets
adopted by DTS.
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> index db165a235cb6d..66d73e9025d6b 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> @@ -18,7 +18,14 @@ properties:
> - const: qcom,sa8255p-ufshc
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
> +
> + reg-names:
> + minItems: 1
> + items:
> + - const: std
> + - const: mcq
[Severity: Medium]
Since the commit message indicates the MCQ I/O address space should be defined
before it gets adopted by DTS, should reg and reg-names strictly require two
items?
Setting minItems to 1 for both properties allows device trees to pass
schema validation with only a single register space.
Additionally, should reg-names be added to the required list to enforce its
presence?
The examples section was also not updated and still demonstrates a single
register space:
compatible = "qcom,sa8255p-ufshc";
reg = <0x01d84000 0x3000>;
interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
Could this be updated to demonstrate the newly added mcq register and
reg-names?
>
> interrupts:
> maxItems: 1
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260720023552.2667237-1-shengchao.guo@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-20 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 2:35 [PATCH v2] scsi: ufs: dt-bindings: Add missing mcq reg for qcom,sa8255p-ufshc Shawn Guo
2026-07-20 2:44 ` sashiko-bot [this message]
2026-07-20 7:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720024444.5F80D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox