Re: [PATCH v6 10/56] scsi: qla2xxx: Add extended status continuation and marker IOCBs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add `sts_cont_entry_ext_t` and `mrk_entry_ext_t`, but the patch only adds `struct sts_cont_entry_ext` and entirely omits the marker structure.
--

--- Patch [10]: [PATCH v6 10/56] scsi: qla2xxx: Add extended status continuation and marker IOCBs ---
commit e3f382fa4d5aa55c429c51349c5574fdb65d9249
Author: Anil Gurumurthy <agurumurthy@marvell.com>

scsi: qla2xxx: Add extended status continuation and marker IOCBs

This commit adds the 128-byte extended status continuation structure and
includes the new qla_fw29.h header for 29xx firmware support.

> scsi: qla2xxx: Add extended status continuation and marker IOCBs
> 
> Add the 128-byte sts_cont_entry_ext_t and mrk_entry_ext_t
> structures required by 29xx firmware.

[ ... ]

> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
[ ... ]
> @@ -2360,6 +2361,15 @@ typedef struct {
>  	uint8_t reserved_2[48];
>  } mrk_entry_t;
>  
> +/* 29xx definitions */
> +struct sts_cont_entry_ext {
> +	uint8_t entry_type;		/* Entry type. */
> +	uint8_t entry_count;		/* Entry count. */
> +	uint8_t sys_define;		/* System defined. */
> +	uint8_t entry_status;		/* Entry Status. */
> +	uint8_t data[124];		/* data */
> +};

[Severity: Medium]
The commit message states that both sts_cont_entry_ext_t and mrk_entry_ext_t
are being added, but only struct sts_cont_entry_ext is present in the code.

Is the mrk_entry_ext_t structure accidentally missing from this patch, or does
the commit message need to be updated?

Additionally, should sts_cont_entry_ext use a typedef to match the
sts_cont_entry_ext_t description in the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723050413.3897522-1-njavali@marvell.com?part=10