Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Kanchan Joshi <joshi.k@samsung.com>,
	Anuj Gupta <anuj20.g@samsung.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/5] common: add a _sysfs_block_integrity_path helper
Date: Fri, 21 Aug 2026 16:29:08 -0700	[thread overview]
Message-ID: <20260821232908.GE839663@frogsfrogsfrogs> (raw)
In-Reply-To: <20260821051133.1817670-3-hch@lst.de>

On Fri, Aug 21, 2026 at 07:11:27AM +0200, Christoph Hellwig wrote:
> Add a helper function to find the sysfs integrity directory for a given
> block device.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  common/rc | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 02bdb31a76a6..61a899da3bd7 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -5257,6 +5257,31 @@ _sysfs_queue_path()
>  	fi
>  }
>  
> +# Get the sysfs block device integrity/ path for a block device, handling
> +# partitions correctly.
> +_sysfs_block_integrity_path()
> +{
> +	local dev parent
> +	dev=$(_short_dev "$1")
> +
> +	# For partitions, integrity details are in the parent device's sysfs dir
> +	if [ -e "/sys/class/block/$dev/partition" ]; then
> +		parent=$(basename "$(readlink -f /sys/class/block/$dev/..)")
> +	else
> +		parent="$dev"
> +	fi

I wonder if this part should get pulled out into a _sysfs_block_path
helper, since the code is already in _sysfs_queue_path?

--D

> +
> +	local integrity_path="/sys/block/$parent/integrity"
> +
> +	# Verify the path exists before returning
> +	if [ -e "$integrity_path" ]; then
> +		echo "$integrity_path"
> +		return 0
> +	fi
> +
> +	return 1
> +}
> +
>  # Get the minimum block size of a file.  Usually this is the
>  # minimum fs block size, but some filesystems (ocfs2) do block
>  # mappings in larger units.
> -- 
> 2.53.0
> 
> 

  reply	other threads:[~2026-08-21 23:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  5:11 add tests for file system on devices using protection information v2 Christoph Hellwig
2026-08-21  5:11 ` [PATCH 1/5] common/scsi_debug: don't slow down I/O Christoph Hellwig
2026-08-21  7:41   ` John Garry
2026-08-21 16:14     ` Bart Van Assche
2026-08-21 23:27       ` Darrick J. Wong
2026-08-21  5:11 ` [PATCH 2/5] common: add a _sysfs_block_integrity_path helper Christoph Hellwig
2026-08-21 23:29   ` Darrick J. Wong [this message]
2026-08-21  5:11 ` [PATCH 3/5] add a "pi" group Christoph Hellwig
2026-08-21 23:30   ` Darrick J. Wong
2026-08-21  5:11 ` [PATCH 4/5] generic: test I/O on devices with T10 protection information Christoph Hellwig
2026-08-21 23:37   ` Darrick J. Wong
2026-08-21  5:11 ` [PATCH 5/5] generic: test corruption detection using " Christoph Hellwig
2026-08-21 23:38   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821232908.GE839663@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=anuj20.g@samsung.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=joshi.k@samsung.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox