From: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
To: krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konradybcio@kernel.org, mani@kernel.org,
James.Bottomley@HansenPartnership.com, mkp@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
Ziqi Chen <ziqi.chen@oss.qualcomm.com>,
Nitin Rawat <nitin.rawat@oss.qualcomm.com>
Subject: [PATCH V1 1/2] scsi: ufs: ufs-qcom: Add specified gear support for multi gear scaling
Date: Sat, 29 Aug 2026 13:13:54 +0530 [thread overview]
Message-ID: <20260829074355.946543-2-nitin.rawat@oss.qualcomm.com> (raw)
In-Reply-To: <20260829074355.946543-1-nitin.rawat@oss.qualcomm.com>
From: Ziqi Chen <ziqi.chen@oss.qualcomm.com>
The UFS clock frequency and gear speed do not necessarily have a strict
one-to-one correspondence on all platforms. Introduce a device tree
based configuration interface that allows specifying the HS gear
speed for each supported operating frequency via the "opp-level"
property in the OPP table. When this property is not configured, the
driver falls back to the default frequency-to-gear mapping table.
Signed-off-by: Ziqi Chen <ziqi.chen@oss.qualcomm.com>
Signed-off-by: Nitin Rawat <nitin.rawat@oss.qualcomm.com>
---
drivers/ufs/host/ufs-qcom.c | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 0f2e083b04fd..aa2ac2cd2b69 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -2460,8 +2460,9 @@ static unsigned long ufs_qcom_opp_freq_to_clk_freq(struct ufs_hba *hba,
bool found = false;
opp = dev_pm_opp_find_freq_exact_indexed(hba->dev, freq, 0, true);
- if (IS_ERR(opp)) {
- dev_err(hba->dev, "Failed to find OPP for exact frequency %lu\n", freq);
+ if (IS_ERR_OR_NULL(opp)) {
+ dev_err(hba->dev, "%s: Failed to find OPP for exact frequency %lu\n",
+ __func__, freq);
return 0;
}
@@ -2489,12 +2490,32 @@ static unsigned long ufs_qcom_opp_freq_to_clk_freq(struct ufs_hba *hba,
static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
{
- u32 gear = UFS_HS_DONT_CHANGE;
+ struct dev_pm_opp *opp;
unsigned long unipro_freq;
+ u32 gear = UFS_HS_DONT_CHANGE;
if (!hba->use_pm_opp)
return gear;
+ opp = dev_pm_opp_find_freq_exact_indexed(hba->dev, freq, 0, true);
+ if (IS_ERR_OR_NULL(opp)) {
+ dev_err(hba->dev, "%s: Failed to find OPP for exact frequency %lu\n",
+ __func__, freq);
+ return gear;
+ }
+
+ /* Get HS gear speed from 'opp-level' */
+ gear = dev_pm_opp_get_level(opp);
+ dev_pm_opp_put(opp);
+
+ /*
+ * Greater than max gear means that there is no specified gear configured in DT
+ * or the specified gear is invalid.
+ */
+ if (gear <= hba->max_pwr_info.info.gear_rx)
+ return gear;
+
+ gear = UFS_HS_DONT_CHANGE;
unipro_freq = ufs_qcom_opp_freq_to_clk_freq(hba, freq, "core_clk_unipro");
switch (unipro_freq) {
case 403000000:
@@ -2515,7 +2536,8 @@ static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
gear = UFS_HS_G1;
break;
default:
- dev_err(hba->dev, "%s: Unsupported clock freq : %lu\n", __func__, freq);
+ dev_err(hba->dev, "%s: Unsupported clock freq [sys_clk: %lu, unipro_clk: %lu]\n",
+ __func__, freq, unipro_freq);
return UFS_HS_DONT_CHANGE;
}
--
2.34.1
next prev parent reply other threads:[~2026-08-29 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 7:43 [PATCH V1 0/2] scsi: ufs: ufs-qcom: Add specified gear support for multi gear scaling Nitin Rawat
2026-08-29 7:43 ` Nitin Rawat [this message]
2026-08-29 7:55 ` [PATCH V1 1/2] " sashiko-bot
2026-08-29 7:43 ` [PATCH V1 2/2] arm64: dts: qcom: Set specified gear configuration for Hamoa Nitin Rawat
2026-08-29 7:53 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829074355.946543-2-nitin.rawat@oss.qualcomm.com \
--to=nitin.rawat@oss.qualcomm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkp@kernel.org \
--cc=robh@kernel.org \
--cc=ziqi.chen@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox