From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F7CE354AEB; Mon, 31 Aug 2026 02:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788141921; cv=none; b=uYZfP4ZOs9bvpkkgZ09NNJ6FU+GDlZLyq7z69xBsnxU/xRRKcUrHJfNLtSuYEq11SwTX7zzl9YrsyrsS5NXMOZbBxp/gQAX3+WBiMQ4hZk47zfI+XnoRFXUas+XtaFwZHFaKAzg2c1GlJVS2odMzNUq/QTMVixUg7Onwx2MXLGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788141921; c=relaxed/simple; bh=UKgyiLlf867sSalaINkPh2YN0NzU2Gmdlpeb83gD738=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r8D7zPGja7+dKiFOxtOaKNfGuZURMw9RcM3YwvSNW3YtVeG9pk0xKTUFz8pOBw5s2AkMxz+jBBO4MudgUcKKrnlCp+Y8hCSN5/QFdySucETYP9KoohclrBNvIf6QCOskxMYSmZSM1T91aUQPxQiyS6CKsHh/aKc4AkIYd2zdDn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eQPmm3Jd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eQPmm3Jd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18EE91F00A3E; Mon, 31 Aug 2026 02:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788141920; bh=pY9Kd8k2h/nUKrON4W6nql61I5ap2cZ9FG2gcHGI33U=; h=From:To:Subject:Date:In-Reply-To:References; b=eQPmm3JdaUk3fHB7tcXbkWWPQ1UJQmUKiS7qXpk0UpVyRApqEHnjhaF0dR4hYkvc0 6qZbmP1U3XRwidJWlBs2gle76e9SDPTqzyxF8ev+/nKQsHzLRjtpfcPa37iEJgzV8O sv4mlZ33rzxZZm6mnvbmWxsUNQjpKyymgS2dOODPizi1nYHGeVSsLC7Wi6/1TX8f5I BIXPalGpmnSYdqZNQFXhzCgyKCW71rzo1bkGaTPYUqFI0cPyiFVDuHn37du9qvmnNb irG618UCiHIUjHhGvCTLixIdZwVCzJ2fUBMNZ285VxC2IqvELMDIB3bpzTRMpSPfVm H+BmO/t8XvXsg== From: Damien Le Moal To: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Niklas Cassel , linux-usb@vger.kernel.org, Alan Stern , Greg Kroah-Hartman Subject: [PATCH 10/37] scsi: ses: use 16-bits defined sense codes Date: Mon, 31 Aug 2026 11:04:24 +0900 Message-ID: <20260831020451.585944-11-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831020451.585944-1-dlemoal@kernel.org> References: <20260831020451.585944-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the SCSI stroage enclosure driver to use the 16-bits sense_code field of struct scsi_failure and replace all hard-coded additional sense codes and additional sense code qualifiers with the enum values defined in include/scsi/scsi_sense.h. This helps with code clarity as the sense codes being processed are easier to test and self-documented. No functional change intended. Signed-off-by: Damien Le Moal --- drivers/scsi/ses.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index 454886c24570..eefeb8b9a75c 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -72,6 +72,9 @@ static void init_device_slot_control(unsigned char *dest_desc, dest_desc[3] &= 0x3c; } +#define POWER_ON_RESET_ANY \ + scsi_sense_code(ASC_POWER_ON_RESET_OR_BUS_DEVICE_RESET_OCCURRED, \ + SCMD_FAILURE_ASCQ_ANY) static int ses_recv_diag(struct scsi_device *sdev, int page_code, void *buf, int bufflen) @@ -89,15 +92,13 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code, struct scsi_failure failure_defs[] = { { .sense_key = UNIT_ATTENTION, - .asc = 0x29, - .ascq = SCMD_FAILURE_ASCQ_ANY, + .sense_code = POWER_ON_RESET_ANY, .allowed = SES_RETRIES, .result = SAM_STAT_CHECK_CONDITION, }, { .sense_key = NOT_READY, - .asc = SCMD_FAILURE_ASC_ANY, - .ascq = SCMD_FAILURE_ASCQ_ANY, + .sense_code = SCMD_FAILURE_SENSE_CODE_ANY, .allowed = SES_RETRIES, .result = SAM_STAT_CHECK_CONDITION, }, @@ -146,15 +147,13 @@ static int ses_send_diag(struct scsi_device *sdev, int page_code, struct scsi_failure failure_defs[] = { { .sense_key = UNIT_ATTENTION, - .asc = 0x29, - .ascq = SCMD_FAILURE_ASCQ_ANY, + .sense_code = POWER_ON_RESET_ANY, .allowed = SES_RETRIES, .result = SAM_STAT_CHECK_CONDITION, }, { .sense_key = NOT_READY, - .asc = SCMD_FAILURE_ASC_ANY, - .ascq = SCMD_FAILURE_ASCQ_ANY, + .sense_code = SCMD_FAILURE_SENSE_CODE_ANY, .allowed = SES_RETRIES, .result = SAM_STAT_CHECK_CONDITION, }, -- 2.55.0