From: sashiko-bot@kernel.org
To: "Damien Le Moal" <dlemoal@kernel.org>
Cc: linux-s390@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-scsi@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
cassel@kernel.org, linux-ide@vger.kernel.org, dlemoal@kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v4 07/40] scsi: core: use 16-bits defined sense codes
Date: Sat, 05 Sep 2026 03:34:42 +0000 [thread overview]
Message-ID: <20260905033443.0AD4C1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260905032224.509860-8-dlemoal@kernel.org>
> Refactor the SCSI core code to use the 16-bits sense_code field of
> struct scsi_sense_hdr and struct scsi_failure and replace all hard-coded
> additional sense codes and additional sense code qualifiers with the enum
> values defined in include/scsi/scsi_sense.h. This helps with code clarity
> as the sense codes being processed are easier to test and self-documented.
>
> No functional change intended, with the exception of a correction of the
> array any_sense_failure_defs in scsi_lib_test_any_sense() which
> erroenously sets result to SCMD_FAILURE_RESULT_ANY instead of
> SAM_STAT_CHECK_CONDITION and does not sets sense_key to
> SCMD_FAILURE_SENSE_KEY_ANY.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260905032224.509860-1-dlemoal@kernel.org?part=7
next prev parent reply other threads:[~2026-09-05 3:34 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 3:21 [PATCH v4 00/40] Use defined 16-bits ASC/ASCQ combinations Damien Le Moal
2026-09-05 3:21 ` [PATCH v4 01/40] scsi: define all additional sense codes and their qualifiers Damien Le Moal
2026-09-05 3:37 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 02/40] scsi: constants: use defined sense codes Damien Le Moal
2026-09-05 3:32 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 03/40] scsi: constants: rename internal struct field names Damien Le Moal
2026-09-05 3:29 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 04/40] scsi: rename sense field of struct scsi_failure Damien Le Moal
2026-09-05 3:30 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 05/40] scsi: prepare for using 16-bits defined sense codes Damien Le Moal
2026-09-05 3:33 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 06/40] scsi: use struct scsi_sense_hdr to log sense keys and codes Damien Le Moal
2026-09-05 3:32 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 07/40] scsi: core: use 16-bits defined sense codes Damien Le Moal
2026-09-05 3:34 ` sashiko-bot [this message]
2026-09-05 6:34 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 08/40] scsi: sd: " Damien Le Moal
2026-09-05 3:37 ` sashiko-bot
2026-09-05 6:38 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 09/40] scsi: sr: " Damien Le Moal
2026-09-05 3:34 ` sashiko-bot
2026-09-05 6:40 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 10/40] scsi: ses: " Damien Le Moal
2026-09-05 3:32 ` sashiko-bot
2026-09-05 6:41 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 11/40] scsi: ch: " Damien Le Moal
2026-09-05 3:32 ` sashiko-bot
2026-09-05 6:43 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 12/40] scsi: st: " Damien Le Moal
2026-09-05 3:31 ` sashiko-bot
2026-09-05 6:45 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 13/40] scsi: device_handlers: hp_sw: " Damien Le Moal
2026-09-05 3:43 ` sashiko-bot
2026-09-05 6:47 ` Johannes Thumshirn
2026-09-05 3:21 ` [PATCH v4 14/40] scsi: device_handlers: rdac: " Damien Le Moal
2026-09-05 3:30 ` sashiko-bot
2026-09-05 3:21 ` [PATCH v4 15/40] scsi: device_handlers: emc: " Damien Le Moal
2026-09-05 3:30 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 16/40] scsi: device_handlers: alua: " Damien Le Moal
2026-09-05 3:35 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 17/40] scsi: mpt3sas: " Damien Le Moal
2026-09-05 3:31 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 18/40] scsi: mpi3mr: " Damien Le Moal
2026-09-05 3:31 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 19/40] scsi: 3w-xxxx: " Damien Le Moal
2026-09-05 3:30 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 20/40] scsi: leapraid: " Damien Le Moal
2026-09-05 3:34 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 21/40] scsi: megaraid: " Damien Le Moal
2026-09-05 3:35 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 22/40] scsi: myrX: " Damien Le Moal
2026-09-05 3:37 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 23/40] scsi: smartpqi: " Damien Le Moal
2026-09-05 3:34 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 24/40] scsi: qla2xxx: " Damien Le Moal
2026-09-05 3:39 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 25/40] scsi: ps3rom: " Damien Le Moal
2026-09-05 3:38 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 26/40] scsi: lpfc: " Damien Le Moal
2026-09-05 3:34 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 27/40] scsi: stex: " Damien Le Moal
2026-09-05 3:38 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 28/40] scsi: mvumi: " Damien Le Moal
2026-09-05 3:45 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 29/40] scsi: libiscsi: " Damien Le Moal
2026-09-05 3:35 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 30/40] scsi: ibmvscsi_tgt: " Damien Le Moal
2026-09-05 3:44 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 31/40] scsi: scsi_debug: " Damien Le Moal
2026-09-05 3:43 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 32/40] scsi: hpsa: " Damien Le Moal
2026-09-05 3:39 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 33/40] scsi: storvsc: " Damien Le Moal
2026-09-05 3:40 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 34/40] target: " Damien Le Moal
2026-09-05 3:43 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 35/40] usb: storage: " Damien Le Moal
2026-09-05 3:38 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 36/40] cdrom: " Damien Le Moal
2026-09-05 3:41 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 37/40] ata: libata: " Damien Le Moal
2026-09-05 3:51 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 38/40] s390: scsi: " Damien Le Moal
2026-09-05 3:39 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 39/40] scsi: cleanup scsi_proto.h Damien Le Moal
2026-09-05 3:41 ` sashiko-bot
2026-09-05 3:22 ` [PATCH v4 40/40] scsi: remove scsi_build_sense() and scsi_build_sense_buffer() Damien Le Moal
2026-09-05 3:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905033443.0AD4C1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox